RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:27:35 +00:00
Code Issues Activity Actions

SQLStudio: Display error message boxes when connections/executions fail

Browse source 
In a GUI application, this is vastly more useful than logging to the
terminal or ignoring the error completely.
This commit is contained in:
Timothy Flynn 2022-12-28 23:19:02 -05:00 • committed by Andreas Kling
parent 5822520e6d
commit 690389ae81
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/DevTools/SQLStudio/MainWidget.cpp
View file

@ -168,7 +168,7 @@ MainWidget::MainWidget()
m_connection_id = *connection_id; m_connection_id = *connection_id;
m_run_script_action->set_enabled(true); m_run_script_action->set_enabled(true);
} else { } else {
warnln("\033[33;1mCould not connect to:\033[0m {}", database_name); GUI::MessageBox::show_error(window(), DeprecatedString::formatted("Could not connect to {}", database_name));
} }
}); });
@ -257,6 +257,12 @@ MainWidget::MainWidget()
m_sql_client->on_execution_success = [this](auto, auto, auto, auto, auto, auto) { m_sql_client->on_execution_success = [this](auto, auto, auto, auto, auto, auto) {
read_next_sql_statement_of_editor(); read_next_sql_statement_of_editor();
}; };
m_sql_client->on_execution_error = [this](auto, auto, auto, auto message) {
auto* editor = active_editor();
VERIFY(editor);
GUI::MessageBox::show_error(window(), DeprecatedString::formatted("Error executing {}\n{}", editor->path(), message));
};
m_sql_client->on_next_result = [this](auto, auto, auto row) { m_sql_client->on_next_result = [this](auto, auto, auto row) {
m_results.append({}); m_results.append({});
m_results.last().ensure_capacity(row.size()); m_results.last().ensure_capacity(row.size());