RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 22:07:36 +00:00
Code Issues Activity Actions

LibWeb: Remove the internal window object from WebEngineCustomData

Browse source 
Now that no one needs a Window just to create prototypes, we can remove
the internal window Object from the main thread VM and get rid of the
HTML::Window include for it.

This finally solves the reference binding to nullptr error in ladybird
that shows up when compiling it with ASAN.
This commit is contained in:
Andrew Kaster 2022-09-30 20:11:51 -06:00 • committed by Linus Groh
parent 56b381aac0
commit 691a7070f4
2 changed files with 2 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Bindings/MainThreadVM.h
View file

@ -13,7 +13,6 @@
#include <LibJS/Runtime/VM.h>
#include <LibWeb/DOM/MutationObserver.h>
#include <LibWeb/HTML/EventLoop/EventLoop.h>
#include <LibWeb/HTML/Window.h>
namespace Web::Bindings {
@ -34,10 +33,6 @@ struct WebEngineCustomData final : public JS::VM::CustomData {
Vector<JS::Handle<DOM::MutationObserver>> mutation_observers;
OwnPtr<JS::ExecutionContext> root_execution_context;
// This object is used as the global object for GC-allocated objects that don't
// belong to a web-facing global object.
JS::Handle<HTML::Window> internal_window_object;
};
struct WebEngineCustomJobCallbackData final : public JS::JobCallback::CustomData {
@ -55,7 +50,6 @@ struct WebEngineCustomJobCallbackData final : public JS::JobCallback::CustomData
HTML::ClassicScript* active_script();
JS::VM& main_thread_vm();
HTML::Window& main_thread_internal_window_object();
void queue_mutation_observer_microtask(DOM::Document&);
NonnullOwnPtr<JS::ExecutionContext> create_a_new_javascript_realm(JS::VM&, Function<JS::Object*(JS::Realm&)> create_global_object, Function<JS::Object*(JS::Realm&)> create_global_this_value);