RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:57:36 +00:00
Code Issues Activity Actions

Kernel: Block initializing the Scheduler on the APs until the BSP initialized global data

Browse source
This commit is contained in:
Tom 2020-06-28 16:05:52 -06:00 • committed by Andreas Kling
parent 2a38cc9a12
commit 691d767fba
1 changed files with 16 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Kernel/Scheduler.cpp
View file

@ -525,12 +525,16 @@ Process* Scheduler::colonel()
void Scheduler::initialize(u32 cpu) void Scheduler::initialize(u32 cpu)
{ {
static Atomic<u32> s_bsp_is_initialized;
ASSERT(&Processor::current() != nullptr); // sanity check ASSERT(&Processor::current() != nullptr); // sanity check
g_scheduler_data = new SchedulerData;
g_finalizer_wait_queue = new WaitQueue;
Thread* idle_thread = nullptr; Thread* idle_thread = nullptr;
if (cpu == 0) { if (cpu == 0) {
ASSERT(s_bsp_is_initialized.load(AK::MemoryOrder::memory_order_consume) == 0);
g_scheduler_data = new SchedulerData;
g_finalizer_wait_queue = new WaitQueue;
g_finalizer_has_work.store(false, AK::MemoryOrder::memory_order_release); g_finalizer_has_work.store(false, AK::MemoryOrder::memory_order_release);
s_colonel_process = Process::create_kernel_process(idle_thread, "colonel", idle_loop); s_colonel_process = Process::create_kernel_process(idle_thread, "colonel", idle_loop);
ASSERT(s_colonel_process); ASSERT(s_colonel_process);
@ -538,12 +542,22 @@ void Scheduler::initialize(u32 cpu)
idle_thread->set_priority(THREAD_PRIORITY_MIN); idle_thread->set_priority(THREAD_PRIORITY_MIN);
idle_thread->set_name(String::format("idle thread #%u", cpu)); idle_thread->set_name(String::format("idle thread #%u", cpu));
} else { } else {
// We need to make sure the BSP initialized the global data first
if (s_bsp_is_initialized.load(AK::MemoryOrder::memory_order_consume) == 0) {
dbg() << "Scheduler CPU #" << cpu << " waiting for BSP to initialize first";
while (s_bsp_is_initialized.load(AK::MemoryOrder::memory_order_consume) == 0) {
}
}
ASSERT(s_colonel_process); ASSERT(s_colonel_process);
idle_thread = s_colonel_process->create_kernel_thread(idle_loop, THREAD_PRIORITY_MIN, String::format("idle thread #%u", cpu), false); idle_thread = s_colonel_process->create_kernel_thread(idle_loop, THREAD_PRIORITY_MIN, String::format("idle thread #%u", cpu), false);
ASSERT(idle_thread); ASSERT(idle_thread);
} }
Processor::current().set_idle_thread(*idle_thread); Processor::current().set_idle_thread(*idle_thread);
if (cpu == 0)
s_bsp_is_initialized.store(1, AK::MemoryOrder::memory_order_release);
} }
void Scheduler::timer_tick(const RegisterState& regs) void Scheduler::timer_tick(const RegisterState& regs)