RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:47:35 +00:00
Code Issues Activity Actions

LibCore+Userland: Use StringViews when calling Core::System::open

Browse source 
For some reason we used raw char pointers sometimes, which caused at
least one heap buffer overflow detected in fuzzing.
This commit is contained in:
kleines Filmröllchen 2022-07-08 23:12:31 +02:00 • committed by Sam Atkins
parent 7dd3c5c981
commit 69218b92a5
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WindowServer/HardwareScreenBackend.cpp
View file

@ -24,7 +24,7 @@ HardwareScreenBackend::HardwareScreenBackend(String device)
ErrorOr<void> HardwareScreenBackend::open()
{
m_framebuffer_fd = TRY(Core::System::open(m_device.characters(), O_RDWR | O_CLOEXEC));
m_framebuffer_fd = TRY(Core::System::open(m_device, O_RDWR | O_CLOEXEC));
GraphicsConnectorProperties properties;
if (graphics_connector_get_properties(m_framebuffer_fd, &properties) < 0)