RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 19:15:07 +00:00
Code Issues Activity Actions

LibJS: "-->" preceded by token on same line isn't start of HTML-like comment

Browse source 
B.1.3 HTML-like Comments

The syntax and semantics of 11.4 is extended as follows except that this
extension is not allowed when parsing source code using the goal symbol
Module:

Syntax (only relevant part included)

    SingleLineHTMLCloseComment ::
        LineTerminatorSequence HTMLCloseComment

    HTMLCloseComment ::
        WhiteSpaceSequence[opt] SingleLineDelimitedCommentSequence[opt] --> SingleLineCommentChars[opt]

Fixes #3810.
This commit is contained in:
Linus Groh 2020-10-29 17:55:24 +00:00 • committed by Andreas Kling
parent a10d09faba
commit 69845ae460
3 changed files with 27 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Libraries/LibJS/Tests/comments-basic.js
View file

@ -1,25 +1,29 @@
test("regular comments", () => {
const source = `var i = 0;
const source = `
var i = 0;
// i++;
/* i++; */
/*
i++;
*/
/**/ i++;
return i;`;
expect(source).toEvalTo(0);
expect(source).toEvalTo(1);
});
test("html comments", () => {
const source = `var i = 0;
const source = `
var i = 0;
var j = 0;
<!-- i++; --> i++;
<!-- i++;
i++;
--> i++;
/**/ --> i++;
j --> i++;
return i;`;
expect(source).toEvalTo(1);
expect(source).toEvalTo(2);
});
test("unterminated multi-line comment", () => {