RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:17:44 +00:00
Code Issues Activity Actions

LibJS: Make Value::as_string() return a PrimitiveString reference

Browse source
This commit is contained in:
Andreas Kling 2020-04-29 12:35:39 +02:00
parent 75f246dde8
commit 698652a548
5 changed files with 15 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibJS/Runtime/Value.cpp
View file

@ -92,7 +92,7 @@ bool Value::to_boolean() const
case Type::Undefined:
return false;
case Type::String:
return !as_string()->string().is_empty();
return !as_string().string().is_empty();
case Type::Object:
return true;
default:
@ -144,7 +144,7 @@ Value Value::to_number() const
return Value(0);
case Type::String: {
// FIXME: Trim whitespace beforehand
auto& string = as_string()->string();
auto& string = as_string().string();
if (string.is_empty())
return Value(0);
if (string == "Infinity" || string == "+Infinity")
@ -334,7 +334,7 @@ Value typed_eq(Interpreter&, Value lhs, Value rhs)
case Value::Type::Number:
return Value(lhs.as_double() == rhs.as_double());
case Value::Type::String:
return Value(lhs.as_string()->string() == rhs.as_string()->string());
return Value(lhs.as_string().string() == rhs.as_string().string());
case Value::Type::Boolean:
return Value(lhs.as_bool() == rhs.as_bool());
case Value::Type::Object: