RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:47:35 +00:00
Code Issues Activity Actions

LibJS: Fix "smallestUnit" property name typo in a couple of places

Browse source 
This is a normative change in the Temporal spec.

See: 900e4bc
This commit is contained in:
Linus Groh 2021-12-18 17:15:43 +00:00
parent 70e6eae27b
commit 69b8079b11
5 changed files with 5 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
View file

@ -359,8 +359,7 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::round)
// b. Set roundTo to ! OrdinaryObjectCreate(null). // b. Set roundTo to ! OrdinaryObjectCreate(null).
round_to = Object::create(global_object, nullptr); round_to = Object::create(global_object, nullptr);
// FIXME: "_smallestUnit_" is a spec bug, see https://github.com/tc39/proposal-temporal/pull/1931 // c. Perform ! CreateDataPropertyOrThrow(roundTo, "smallestUnit", paramString).
// c. Perform ! CreateDataPropertyOrThrow(roundTo, "_smallestUnit_", paramString).
MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0))); MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0)));
} }
// 5. Else, // 5. Else,

3
Userland/Libraries/LibJS/Runtime/Temporal/InstantPrototype.cpp
View file

@ -265,8 +265,7 @@ JS_DEFINE_NATIVE_FUNCTION(InstantPrototype::round)
// b. Set roundTo to ! OrdinaryObjectCreate(null). // b. Set roundTo to ! OrdinaryObjectCreate(null).
round_to = Object::create(global_object, nullptr); round_to = Object::create(global_object, nullptr);
// FIXME: "_smallestUnit_" is a spec bug, see https://github.com/tc39/proposal-temporal/pull/1931 // c. Perform ! CreateDataPropertyOrThrow(roundTo, "smallestUnit", paramString).
// c. Perform ! CreateDataPropertyOrThrow(roundTo, "_smallestUnit_", paramString).
MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0))); MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0)));
} }
// 5. Else, // 5. Else,

3
Userland/Libraries/LibJS/Runtime/Temporal/PlainDateTimePrototype.cpp
View file

@ -641,8 +641,7 @@ JS_DEFINE_NATIVE_FUNCTION(PlainDateTimePrototype::round)
// b. Set roundTo to ! OrdinaryObjectCreate(null). // b. Set roundTo to ! OrdinaryObjectCreate(null).
round_to = Object::create(global_object, nullptr); round_to = Object::create(global_object, nullptr);
// FIXME: "_smallestUnit_" is a spec bug, see https://github.com/tc39/proposal-temporal/pull/1931 // c. Perform ! CreateDataPropertyOrThrow(roundTo, "smallestUnit", paramString).
// c. Perform ! CreateDataPropertyOrThrow(roundTo, "_smallestUnit_", paramString).
MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0))); MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0)));
} }
// 5. Else, // 5. Else,

3
Userland/Libraries/LibJS/Runtime/Temporal/PlainTimePrototype.cpp
View file

@ -365,8 +365,7 @@ JS_DEFINE_NATIVE_FUNCTION(PlainTimePrototype::round)
// b. Set roundTo to ! OrdinaryObjectCreate(null). // b. Set roundTo to ! OrdinaryObjectCreate(null).
round_to = Object::create(global_object, nullptr); round_to = Object::create(global_object, nullptr);
// FIXME: "_smallestUnit_" is a spec bug, see https://github.com/tc39/proposal-temporal/pull/1931 // c. Perform ! CreateDataPropertyOrThrow(roundTo, "smallestUnit", paramString).
// c. Perform ! CreateDataPropertyOrThrow(roundTo, "_smallestUnit_", paramString).
MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0))); MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0)));
} }
// 5. Else, // 5. Else,

3
Userland/Libraries/LibJS/Runtime/Temporal/ZonedDateTimePrototype.cpp
View file

@ -1117,8 +1117,7 @@ JS_DEFINE_NATIVE_FUNCTION(ZonedDateTimePrototype::round)
// b. Set roundTo to ! OrdinaryObjectCreate(null). // b. Set roundTo to ! OrdinaryObjectCreate(null).
round_to = Object::create(global_object, nullptr); round_to = Object::create(global_object, nullptr);
// FIXME: "_smallestUnit_" is a spec bug, see https://github.com/tc39/proposal-temporal/pull/1931 // c. Perform ! CreateDataPropertyOrThrow(roundTo, "smallestUnit", paramString).
// c. Perform ! CreateDataPropertyOrThrow(roundTo, "_smallestUnit_", paramString).
MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0))); MUST(round_to->create_data_property_or_throw(vm.names.smallestUnit, vm.argument(0)));
} }
// 5. Else, // 5. Else,