RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-16 21:32:10 +00:00
Code Issues Activity Actions

LibDSP: Remove unused Effects::Delay::m_old_delay_size member

Browse source 
SonarCloud flagged this as m_delay_buffer is technically uninitialized
at the point at which the POD types are initialized in a constructor.

I don't check to see if this was actually a real issue, as the member
is ultimately unused. So lets just get rid of it.
This commit is contained in:
Brian Gianforcaro 2021-09-27 19:21:47 -07:00 • committed by Andreas Kling
parent 8fcdc255ff
commit 69bc04d870
2 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibDSP/Effects.cpp
View file

@ -29,7 +29,6 @@ void Delay::handle_delay_time_change()
if (sample_count != m_delay_buffer.size()) { if (sample_count != m_delay_buffer.size()) {
m_delay_buffer.resize(sample_count, true); m_delay_buffer.resize(sample_count, true);
m_delay_index %= max(m_delay_buffer.size(), 1); m_delay_index %= max(m_delay_buffer.size(), 1);
m_old_delay_size = m_delay_buffer.size();
} }
} }

1
Userland/Libraries/LibDSP/Effects.h
View file

@ -29,7 +29,6 @@ private:
Vector<Sample> m_delay_buffer; Vector<Sample> m_delay_buffer;
size_t m_delay_index { 0 }; size_t m_delay_index { 0 };
size_t m_old_delay_size = m_delay_buffer.size();
}; };
// A simple effect that applies volume, mute and pan to its input signal. // A simple effect that applies volume, mute and pan to its input signal.