RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 14:57:34 +00:00
Code Issues Activity Actions

LibSQL: Free heap storage when deleting rows

Browse source
This commit is contained in:
Jelle Raaijmakers 2023-05-24 15:57:34 +02:00 • committed by Tim Flynn
parent c58c87d7ef
commit 69e09fed39
3 changed files with 33 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibSQL/Database.cpp
View file

@ -6,7 +6,6 @@
*/
#include <AK/DeprecatedString.h>
#include <AK/NonnullRefPtr.h>
#include <LibSQL/BTree.h>
#include <LibSQL/Database.h>
#include <LibSQL/Heap.h>
@ -217,6 +216,8 @@ ErrorOr<void> Database::remove(Row& row)
auto& table = row.table();
VERIFY(m_table_cache.get(table.key().hash()).has_value());
TRY(m_heap->free_storage(row.block_index()));
if (table.block_index() == row.block_index()) {
auto table_key = table.key();
table_key.set_block_index(row.next_block_index());

2
Userland/Libraries/LibSQL/Database.h
View file

@ -8,6 +8,7 @@
#pragma once
#include <AK/DeprecatedString.h>
#include <AK/NonnullRefPtr.h>
#include <AK/RefPtr.h>
#include <LibCore/Object.h>
#include <LibSQL/Forward.h>
@ -32,6 +33,7 @@ public:
ResultOr<void> open();
bool is_open() const { return m_open; }
ErrorOr<void> commit();
ErrorOr<size_t> file_size_in_bytes() const { return m_heap->file_size_in_bytes(); }
ResultOr<void> add_schema(SchemaDef const&);
static Key get_schema_key(DeprecatedString const&);