From 69e9f9ff638573d5a79012a298989246bd0995c1 Mon Sep 17 00:00:00 2001 From: Zaggy1024 Date: Thu, 2 Feb 2023 05:15:36 -0600 Subject: [PATCH] LibVideo/VP9: Prevent negation overflow in BitStream::read_s --- Userland/Libraries/LibVideo/VP9/BitStream.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibVideo/VP9/BitStream.cpp b/Userland/Libraries/LibVideo/VP9/BitStream.cpp index 8b8fba12ab..e9f6ba371c 100644 --- a/Userland/Libraries/LibVideo/VP9/BitStream.cpp +++ b/Userland/Libraries/LibVideo/VP9/BitStream.cpp @@ -145,8 +145,8 @@ ErrorOr BitStream::read_literal(u8 n) ErrorOr BitStream::read_s(size_t n) { - auto value = TRY(read_bits(n)); - auto sign = TRY(read_bit()); + i8 value = TRY(read_bits(n)); + bool sign = TRY(read_bit()); return sign ? -value : value; }