From 69fc7009bfdaec1f52be7d2f072fb6742e45e64e Mon Sep 17 00:00:00 2001 From: Simon Wanner Date: Sun, 20 Mar 2022 19:11:03 +0100 Subject: [PATCH] LibWeb: Grey out invisible nodes in the DOM inspector This makes it easier to navigate large DOM trees where some nodes have display: none --- Userland/Libraries/LibWeb/DOM/Node.cpp | 2 ++ Userland/Libraries/LibWeb/DOMTreeModel.cpp | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Userland/Libraries/LibWeb/DOM/Node.cpp b/Userland/Libraries/LibWeb/DOM/Node.cpp index 364c4ea69c..71220abf93 100644 --- a/Userland/Libraries/LibWeb/DOM/Node.cpp +++ b/Userland/Libraries/LibWeb/DOM/Node.cpp @@ -793,6 +793,8 @@ void Node::serialize_tree_as_json(JsonObjectSerializer& object) c MUST(object.add("data"sv, static_cast(*this).data())); } + MUST((object.add("visible"sv, !!layout_node()))); + if (has_child_nodes()) { auto children = MUST(object.add_array("children")); for_each_child([&children](DOM::Node& child) { diff --git a/Userland/Libraries/LibWeb/DOMTreeModel.cpp b/Userland/Libraries/LibWeb/DOMTreeModel.cpp index cd8a9302f5..dbfca80b34 100644 --- a/Userland/Libraries/LibWeb/DOMTreeModel.cpp +++ b/Userland/Libraries/LibWeb/DOMTreeModel.cpp @@ -126,6 +126,8 @@ GUI::Variant DOMTreeModel::data(const GUI::ModelIndex& index, GUI::ModelRole rol return m_tree_view.palette().syntax_comment(); if (type == "pseudo-element"sv) return m_tree_view.palette().syntax_type(); + if (!node.get("visible").to_bool(true)) + return m_tree_view.palette().syntax_comment(); return {}; }