RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:08:11 +00:00
Code Issues Activity Actions

LibGUI+VisualBuilder: Support custom editing widgets for property values.

Browse source 
Implemented this by letting GAbstractViews provide a GModelEditingDelegate
for a given index, which then knows how to create and setup a custom widget
appropriate for the data type being edited.
This commit is contained in:
Andreas Kling 2019-06-23 08:18:28 +02:00
parent 1d0ada32cc
commit 6a0011dcea
8 changed files with 170 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

59
DevTools/VisualBuilder/VBPropertiesWindow.cpp
View file

@ -1,9 +1,55 @@
#include "VBPropertiesWindow.h"
#include "VBWidgetPropertyModel.h"
#include <LibGUI/GBoxLayout.h>
#include <LibGUI/GComboBox.h>
#include <LibGUI/GModelEditingDelegate.h>
#include <LibGUI/GTableView.h>
#include <LibGUI/GTextBox.h>
#include <LibGUI/GWidget.h>
class BoolValuesModel final : public GModel {
public:
virtual int row_count(const GModelIndex&) const override { return 2; }
virtual int column_count(const GModelIndex&) const override { return 1; }
virtual void update() override {}
virtual GVariant data(const GModelIndex& index, Role role) const override
{
if (role != Role::Display)
return {};
switch (index.row()) {
case 0:
return "false";
case 1:
return "true";
}
ASSERT_NOT_REACHED();
}
};
class BoolModelEditingDelegate : public GModelEditingDelegate {
public:
BoolModelEditingDelegate() {}
virtual ~BoolModelEditingDelegate() override {}
virtual GWidget* create_widget() override
{
auto* combo = new GComboBox(nullptr);
combo->set_only_allow_values_from_model(true);
combo->set_model(adopt(*new BoolValuesModel));
combo->on_return_pressed = [this] { commit(); };
combo->on_change = [this](auto&) { commit(); };
return combo;
}
virtual GVariant value() const override { return static_cast<const GComboBox*>(widget())->text() == "true"; }
virtual void set_value(const GVariant& value) override { static_cast<GComboBox*>(widget())->set_text(value.to_string()); }
virtual void will_begin_editing() override
{
auto& combo = *static_cast<GComboBox*>(widget());
combo.select_all();
combo.open();
}
};
VBPropertiesWindow::VBPropertiesWindow()
{
set_title("Properties");
@ -18,6 +64,19 @@ VBPropertiesWindow::VBPropertiesWindow()
m_table_view = new GTableView(widget);
m_table_view->set_headers_visible(false);
m_table_view->set_editable(true);
m_table_view->aid_create_editing_delegate = [this](auto& index) -> OwnPtr<GModelEditingDelegate> {
if (!m_table_view->model())
return nullptr;
auto type_index = m_table_view->model()->index(index.row(), VBWidgetPropertyModel::Column::Type);
auto type = m_table_view->model()->data(type_index, GModel::Role::Custom).to_int();
switch ((GVariant::Type)type) {
case GVariant::Type::Bool:
return make<BoolModelEditingDelegate>();
default:
return make<GStringModelEditingDelegate>();
}
};
}
VBPropertiesWindow::~VBPropertiesWindow()