RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 15:37:46 +00:00
Code Issues Activity Actions

LibWeb/LibJS: Avoid GC visit of raw pointers where possible

Browse source 
This is mostly motivated for aesthetics, but also helps avoid some null
checks when we have a NonnullGCPtr<T> or in some cases a T&.
This commit is contained in:
Shannon Booth 2023-11-19 16:18:00 +13:00 • committed by Sam Atkins
parent 4e04f81626
commit 6a2a7cad61
54 changed files with 100 additions and 100 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/AbortController.cpp
View file

@ -34,7 +34,7 @@ void AbortController::initialize(JS::Realm& realm)
void AbortController::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_signal.ptr());
visitor.visit(m_signal);
}
// https://dom.spec.whatwg.org/#dom-abortcontroller-abort

4
Userland/Libraries/LibWeb/DOM/AbstractRange.cpp
View file

@ -30,8 +30,8 @@ void AbstractRange::initialize(JS::Realm& realm)
void AbstractRange::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_start_container.ptr());
visitor.visit(m_end_container.ptr());
visitor.visit(m_start_container);
visitor.visit(m_end_container);
}
}

2
Userland/Libraries/LibWeb/DOM/Attr.cpp
View file

@ -47,7 +47,7 @@ void Attr::initialize(JS::Realm& realm)
void Attr::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_owner_element.ptr());
visitor.visit(m_owner_element);
}
Element* Attr::owner_element()

4
Userland/Libraries/LibWeb/DOM/DOMEventListener.cpp
View file

@ -16,8 +16,8 @@ DOMEventListener::~DOMEventListener() = default;
void DOMEventListener::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(callback.ptr());
visitor.visit(signal.ptr());
visitor.visit(callback);
visitor.visit(signal);
}
}

2
Userland/Libraries/LibWeb/DOM/DocumentFragment.cpp
View file

@ -23,7 +23,7 @@ void DocumentFragment::initialize(JS::Realm& realm)
void DocumentFragment::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_host.ptr());
visitor.visit(m_host);
}
void DocumentFragment::set_host(Web::DOM::Element* element)

10
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -120,11 +120,11 @@ void Element::visit_edges(Cell::Visitor& visitor)
Base::visit_edges(visitor);
SlottableMixin::visit_edges(visitor);
visitor.visit(m_attributes.ptr());
visitor.visit(m_inline_style.ptr());
visitor.visit(m_class_list.ptr());
visitor.visit(m_shadow_root.ptr());
visitor.visit(m_custom_element_definition.ptr());
visitor.visit(m_attributes);
visitor.visit(m_inline_style);
visitor.visit(m_class_list);
visitor.visit(m_shadow_root);
visitor.visit(m_custom_element_definition);
for (auto& pseudo_element_layout_node : m_pseudo_element_nodes)
visitor.visit(pseudo_element_layout_node);
for (auto& registered_intersection_observers : m_registered_intersection_observers)

16
Userland/Libraries/LibWeb/DOM/Event.cpp
View file

@ -50,18 +50,18 @@ void Event::initialize(JS::Realm& realm)
void Event::visit_edges(Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_target.ptr());
visitor.visit(m_related_target.ptr());
visitor.visit(m_current_target.ptr());
visitor.visit(m_target);
visitor.visit(m_related_target);
visitor.visit(m_current_target);
for (auto& it : m_path) {
visitor.visit(it.invocation_target.ptr());
visitor.visit(it.shadow_adjusted_target.ptr());
visitor.visit(it.related_target.ptr());
visitor.visit(it.invocation_target);
visitor.visit(it.shadow_adjusted_target);
visitor.visit(it.related_target);
for (auto& itit : it.touch_target_list)
visitor.visit(itit.ptr());
visitor.visit(itit);
}
for (auto& it : m_touch_target_list)
visitor.visit(it.ptr());
visitor.visit(it);
}
// https://dom.spec.whatwg.org/#concept-event-path-append

4
Userland/Libraries/LibWeb/DOM/EventTarget.cpp
View file

@ -67,10 +67,10 @@ void EventTarget::visit_edges(Cell::Visitor& visitor)
Base::visit_edges(visitor);
for (auto& event_listener : m_event_listener_list)
visitor.visit(event_listener.ptr());
visitor.visit(event_listener);
for (auto& it : m_event_handler_map)
visitor.visit(it.value.ptr());
visitor.visit(it.value);
}
Vector<JS::Handle<DOMEventListener>> EventTarget::event_listener_list()

2
Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp
View file

@ -37,7 +37,7 @@ void HTMLCollection::initialize(JS::Realm& realm)
void HTMLCollection::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_root.ptr());
visitor.visit(m_root);
}
JS::MarkedVector<Element*> HTMLCollection::collect_matching_elements() const

2
Userland/Libraries/LibWeb/DOM/IDLEventListener.cpp
View file

@ -24,7 +24,7 @@ IDLEventListener::IDLEventListener(JS::Realm& realm, JS::NonnullGCPtr<WebIDL::Ca
void IDLEventListener::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_callback.ptr());
visitor.visit(m_callback);
}
}

2
Userland/Libraries/LibWeb/DOM/LiveNodeList.cpp
View file

@ -30,7 +30,7 @@ LiveNodeList::~LiveNodeList() = default;
void LiveNodeList::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_root.ptr());
visitor.visit(m_root);
}
JS::MarkedVector<Node*> LiveNodeList::collection() const

8
Userland/Libraries/LibWeb/DOM/MutationObserver.cpp
View file

@ -46,9 +46,9 @@ void MutationObserver::initialize(JS::Realm& realm)
void MutationObserver::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_callback.ptr());
visitor.visit(m_callback);
for (auto& record : m_record_queue)
visitor.visit(record.ptr());
visitor.visit(record);
}
// https://dom.spec.whatwg.org/#dom-mutationobserver-observe
@ -167,7 +167,7 @@ RegisteredObserver::~RegisteredObserver() = default;
void RegisteredObserver::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_observer.ptr());
visitor.visit(m_observer);
}
JS::NonnullGCPtr<TransientRegisteredObserver> TransientRegisteredObserver::create(MutationObserver& observer, MutationObserverInit const& options, RegisteredObserver& source)
@ -186,7 +186,7 @@ TransientRegisteredObserver::~TransientRegisteredObserver() = default;
void TransientRegisteredObserver::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_source.ptr());
visitor.visit(m_source);
}
}

10
Userland/Libraries/LibWeb/DOM/MutationRecord.cpp
View file

@ -42,11 +42,11 @@ void MutationRecord::initialize(JS::Realm& realm)
void MutationRecord::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_target.ptr());
visitor.visit(m_added_nodes.ptr());
visitor.visit(m_removed_nodes.ptr());
visitor.visit(m_previous_sibling.ptr());
visitor.visit(m_next_sibling.ptr());
visitor.visit(m_target);
visitor.visit(m_added_nodes);
visitor.visit(m_removed_nodes);
visitor.visit(m_previous_sibling);
visitor.visit(m_next_sibling);
}
}

4
Userland/Libraries/LibWeb/DOM/NamedNodeMap.cpp
View file

@ -34,9 +34,9 @@ void NamedNodeMap::initialize(JS::Realm& realm)
void NamedNodeMap::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_element.ptr());
visitor.visit(m_element);
for (auto& attribute : m_attributes)
visitor.visit(attribute.ptr());
visitor.visit(attribute);
}
// https://dom.spec.whatwg.org/#ref-for-dfn-supported-property-indices%E2%91%A3

12
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -92,12 +92,12 @@ void Node::finalize()
void Node::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_document.ptr());
visitor.visit(m_parent.ptr());
visitor.visit(m_first_child.ptr());
visitor.visit(m_last_child.ptr());
visitor.visit(m_next_sibling.ptr());
visitor.visit(m_previous_sibling.ptr());
visitor.visit(m_document);
visitor.visit(m_parent);
visitor.visit(m_first_child);
visitor.visit(m_last_child);
visitor.visit(m_next_sibling);
visitor.visit(m_previous_sibling);
visitor.visit(m_child_nodes);
visitor.visit(m_layout_node);

8
Userland/Libraries/LibWeb/DOM/NodeIterator.cpp
View file

@ -36,12 +36,12 @@ void NodeIterator::finalize()
void NodeIterator::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_filter.ptr());
visitor.visit(m_root.ptr());
visitor.visit(m_reference.node.ptr());
visitor.visit(m_filter);
visitor.visit(m_root);
visitor.visit(m_reference.node);
if (m_traversal_pointer.has_value())
visitor.visit(m_traversal_pointer->node.ptr());
visitor.visit(m_traversal_pointer->node);
}
// https://dom.spec.whatwg.org/#dom-document-createnodeiterator

6
Userland/Libraries/LibWeb/DOM/TreeWalker.cpp
View file

@ -31,9 +31,9 @@ void TreeWalker::initialize(JS::Realm& realm)
void TreeWalker::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_filter.ptr());
visitor.visit(m_root.ptr());
visitor.visit(m_current.ptr());
visitor.visit(m_filter);
visitor.visit(m_root);
visitor.visit(m_current);
}
// https://dom.spec.whatwg.org/#dom-document-createtreewalker