RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:27:43 +00:00
Code Issues Activity Actions

LibWeb/LibJS: Avoid GC visit of raw pointers where possible

Browse source 
This is mostly motivated for aesthetics, but also helps avoid some null
checks when we have a NonnullGCPtr<T> or in some cases a T&.
This commit is contained in:
Shannon Booth 2023-11-19 16:18:00 +13:00 • committed by Sam Atkins
parent 4e04f81626
commit 6a2a7cad61
54 changed files with 100 additions and 100 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/DOM/MutationObserver.cpp
View file

@ -46,9 +46,9 @@ void MutationObserver::initialize(JS::Realm& realm)
void MutationObserver::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_callback.ptr());
visitor.visit(m_callback);
for (auto& record : m_record_queue)
visitor.visit(record.ptr());
visitor.visit(record);
}
// https://dom.spec.whatwg.org/#dom-mutationobserver-observe
@ -167,7 +167,7 @@ RegisteredObserver::~RegisteredObserver() = default;
void RegisteredObserver::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_observer.ptr());
visitor.visit(m_observer);
}
JS::NonnullGCPtr<TransientRegisteredObserver> TransientRegisteredObserver::create(MutationObserver& observer, MutationObserverInit const& options, RegisteredObserver& source)
@ -186,7 +186,7 @@ TransientRegisteredObserver::~TransientRegisteredObserver() = default;
void TransientRegisteredObserver::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);
visitor.visit(m_source.ptr());
visitor.visit(m_source);
}
}