From 6a7c5608496bfd6efad1a70fb6b7e3b135657cc4 Mon Sep 17 00:00:00 2001
From: Luke Wilde <lukew@serenityos.org>
Date: Mon, 10 Oct 2022 17:22:30 +0100
Subject: [PATCH] LibWeb: Respect width and height attributes of <iframe>

We have to respect the width and height attributes of <iframe> elements
the same way as <img> elements.
---
 .../Libraries/LibWeb/HTML/HTMLIFrameElement.cpp   | 15 +++++++++++++++
 .../Libraries/LibWeb/HTML/HTMLIFrameElement.h     |  2 ++
 2 files changed, 17 insertions(+)

diff --git a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
index 399e1f9676..006640eabc 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
+++ b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.cpp
@@ -9,6 +9,7 @@
 #include <LibWeb/HTML/BrowsingContext.h>
 #include <LibWeb/HTML/HTMLIFrameElement.h>
 #include <LibWeb/HTML/Origin.h>
+#include <LibWeb/HTML/Parser/HTMLParser.h>
 #include <LibWeb/Layout/FrameBox.h>
 
 namespace Web::HTML {
@@ -126,6 +127,20 @@ void HTMLIFrameElement::load_src(String const& value)
     m_nested_browsing_context->loader().load(url, FrameLoader::Type::IFrame);
 }
 
+// https://html.spec.whatwg.org/multipage/rendering.html#attributes-for-embedded-content-and-images
+void HTMLIFrameElement::apply_presentational_hints(CSS::StyleProperties& style) const
+{
+    for_each_attribute([&](auto& name, auto& value) {
+        if (name == HTML::AttributeNames::width) {
+            if (auto parsed_value = parse_dimension_value(value))
+                style.set_property(CSS::PropertyID::Width, parsed_value.release_nonnull());
+        } else if (name == HTML::AttributeNames::height) {
+            if (auto parsed_value = parse_dimension_value(value))
+                style.set_property(CSS::PropertyID::Height, parsed_value.release_nonnull());
+        }
+    });
+}
+
 // https://html.spec.whatwg.org/multipage/iframe-embed-object.html#iframe-load-event-steps
 void run_iframe_load_event_steps(HTML::HTMLIFrameElement& element)
 {
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h
index 3ae2a16bab..d7aba28e14 100644
--- a/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h
+++ b/Userland/Libraries/LibWeb/HTML/HTMLIFrameElement.h
@@ -23,6 +23,8 @@ public:
 
     void set_current_navigation_was_lazy_loaded(bool value) { m_current_navigation_was_lazy_loaded = value; }
 
+    virtual void apply_presentational_hints(CSS::StyleProperties&) const override;
+
 private:
     HTMLIFrameElement(DOM::Document&, DOM::QualifiedName);