From 6b35cca65bbc49ffee071bbdd7de561c453f631c Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Fri, 14 Apr 2023 15:56:20 +0200 Subject: [PATCH] LibWeb/Streams: Add FIXMEs to incorrect invoke_callback() invocations --- Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp b/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp index 309a038350..c10fd4a212 100644 --- a/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp +++ b/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp @@ -726,6 +726,7 @@ WebIDL::ExceptionOr set_up_readable_stream_default_controller_from_underly // 5. If underlyingSourceDict["start"] exists, then set startAlgorithm to an algorithm which returns the result of invoking underlyingSourceDict["start"] with argument list « controller » and callback this value underlyingSource. if (underlying_source.start) { start_algorithm = [&, start = underlying_source.start]() -> WebIDL::ExceptionOr> { + // FIXME: This needs to create a rejected Promise for throw completions, which invoke_callback() currently doesn't do. auto result = TRY(WebIDL::invoke_callback(*start, underlying_source_value, controller)).release_value(); return WebIDL::create_resolved_promise(realm, result); }; @@ -734,6 +735,7 @@ WebIDL::ExceptionOr set_up_readable_stream_default_controller_from_underly // 6. If underlyingSourceDict["pull"] exists, then set pullAlgorithm to an algorithm which returns the result of invoking underlyingSourceDict["pull"] with argument list « controller » and callback this value underlyingSource. if (underlying_source.pull) { pull_algorithm = [&, pull = underlying_source.pull]() -> WebIDL::ExceptionOr> { + // FIXME: This needs to create a rejected Promise for throw completions, which invoke_callback() currently doesn't do. auto result = TRY(WebIDL::invoke_callback(*pull, underlying_source_value, controller)).release_value(); return WebIDL::create_resolved_promise(realm, result); }; @@ -742,6 +744,7 @@ WebIDL::ExceptionOr set_up_readable_stream_default_controller_from_underly // 7. If underlyingSourceDict["cancel"] exists, then set cancelAlgorithm to an algorithm which takes an argument reason and returns the result of invoking underlyingSourceDict["cancel"] with argument list « reason » and callback this value underlyingSource. if (underlying_source.cancel) { cancel_algorithm = [&, cancel = underlying_source.cancel](auto const& reason) -> WebIDL::ExceptionOr> { + // FIXME: This needs to create a rejected Promise for throw completions, which invoke_callback() currently doesn't do. auto result = TRY(WebIDL::invoke_callback(*cancel, underlying_source_value, reason)).release_value(); return WebIDL::create_resolved_promise(realm, result); }; @@ -1729,6 +1732,7 @@ WebIDL::ExceptionOr set_up_writable_stream_default_controller_from_underly // 6. If underlyingSinkDict["start"] exists, then set startAlgorithm to an algorithm which returns the result of invoking underlyingSinkDict["start"] with argument list « controller » and callback this value underlyingSink. if (underlying_sink.start) { start_algorithm = [&, callback = underlying_sink.start]() -> WebIDL::ExceptionOr> { + // FIXME: This needs to create a rejected Promise for throw completions, which invoke_callback() currently doesn't do. auto result = TRY(WebIDL::invoke_callback(*callback, underlying_sink_value, controller)).release_value(); return WebIDL::create_resolved_promise(realm, result); }; @@ -1737,6 +1741,7 @@ WebIDL::ExceptionOr set_up_writable_stream_default_controller_from_underly // 7. If underlyingSinkDict["write"] exists, then set writeAlgorithm to an algorithm which takes an argument chunk and returns the result of invoking underlyingSinkDict["write"] with argument list « chunk, controller » and callback this value underlyingSink. if (underlying_sink.write) { write_algorithm = [&, callback = underlying_sink.write](JS::Value chunk) -> WebIDL::ExceptionOr> { + // FIXME: This needs to create a rejected Promise for throw completions, which invoke_callback() currently doesn't do. auto result = TRY(WebIDL::invoke_callback(*callback, underlying_sink_value, chunk, controller)).release_value(); return WebIDL::create_resolved_promise(realm, result); }; @@ -1745,6 +1750,7 @@ WebIDL::ExceptionOr set_up_writable_stream_default_controller_from_underly // 8. If underlyingSinkDict["close"] exists, then set closeAlgorithm to an algorithm which returns the result of invoking underlyingSinkDict["close"] with argument list «» and callback this value underlyingSink. if (underlying_sink.close) { close_algorithm = [&, callback = underlying_sink.close]() -> WebIDL::ExceptionOr> { + // FIXME: This needs to create a rejected Promise for throw completions, which invoke_callback() currently doesn't do. auto result = TRY(WebIDL::invoke_callback(*callback, underlying_sink_value)).release_value(); return WebIDL::create_resolved_promise(realm, result); }; @@ -1753,6 +1759,7 @@ WebIDL::ExceptionOr set_up_writable_stream_default_controller_from_underly // 9. If underlyingSinkDict["abort"] exists, then set abortAlgorithm to an algorithm which takes an argument reason and returns the result of invoking underlyingSinkDict["abort"] with argument list « reason » and callback this value underlyingSink. if (underlying_sink.abort) { abort_algorithm = [&, callback = underlying_sink.abort](JS::Value reason) -> WebIDL::ExceptionOr> { + // FIXME: This needs to create a rejected Promise for throw completions, which invoke_callback() currently doesn't do. auto result = TRY(WebIDL::invoke_callback(*callback, underlying_sink_value, reason)).release_value(); return WebIDL::create_resolved_promise(realm, result); };