RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:57:35 +00:00
Code Issues Activity Actions

IPv4: Send TCP packets right away instead of waiting to "retry"

Browse source 
Also be more explicit about zero-initializing OutgoingPacket objects.
This commit is contained in:
Andreas Kling 2020-02-08 01:43:55 +01:00
parent a7e72f78cd
commit 6be880bd10
2 changed files with 4 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/Net/TCPSocket.cpp
View file

@ -190,7 +190,7 @@ void TCPSocket::send_tcp_packet(u16 flags, const void* payload, size_t payload_s
if (tcp_packet.has_syn() || payload_size > 0) { if (tcp_packet.has_syn() || payload_size > 0) {
LOCKER(m_not_acked_lock); LOCKER(m_not_acked_lock);
m_not_acked.append({ m_sequence_number, move(buffer), 0, {} }); m_not_acked.append({ m_sequence_number, move(buffer) });
send_outgoing_packets(); send_outgoing_packets();
return; return;
} }
@ -217,9 +217,8 @@ void TCPSocket::send_outgoing_packets()
for (auto& packet : m_not_acked) { for (auto& packet : m_not_acked) {
timeval diff; timeval diff;
timeval_sub(packet.tx_time, now, diff); timeval_sub(packet.tx_time, now, diff);
if (diff.tv_sec < 1 && diff.tv_usec <= 500000) if (diff.tv_sec == 0 && diff.tv_usec <= 500000)
continue; continue;
packet.tx_time = now; packet.tx_time = now;
packet.tx_counter++; packet.tx_counter++;

4
Kernel/Net/TCPSocket.h
View file

@ -192,10 +192,10 @@ private:
u32 m_bytes_out { 0 }; u32 m_bytes_out { 0 };
struct OutgoingPacket { struct OutgoingPacket {
u32 ack_number; u32 ack_number { 0 };
ByteBuffer buffer; ByteBuffer buffer;
int tx_counter { 0 }; int tx_counter { 0 };
timeval tx_time; timeval tx_time { 0, 0 };
}; };
Lock m_not_acked_lock { "TCPSocket unacked packets" }; Lock m_not_acked_lock { "TCPSocket unacked packets" };