RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:48:12 +00:00
Code Issues Activity Actions

LibGUI+ThemeEditor: Split preview-widget palette-change callback

Browse source 
There are two different things in ThemeEditor that want to know when a
palette changes:
1. The PreviewWidget subclass, so it can update its preview.
2. The ThemeEditor itself, so we know that the palette is modified.

Using a protected virtual function for 1 means that we can do 2 without
them fighting over the same on_palette_change callback.
This commit is contained in:
Sam Atkins 2022-04-29 12:07:06 +01:00 • committed by Andreas Kling
parent 5fd0140772
commit 6c572006a3
4 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibGUI/AbstractThemePreview.cpp
View file

@ -1,6 +1,6 @@
/*
* Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2021-2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2021, Antonio Di Stefano <tonio9681@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
*
@ -71,9 +71,9 @@ void AbstractThemePreview::load_theme_bitmaps()
void AbstractThemePreview::set_preview_palette(Gfx::Palette const& palette)
{
m_preview_palette = palette;
if (on_palette_change) {
palette_changed();
if (on_palette_change)
on_palette_change();
}
load_theme_bitmaps();
update();
}