RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:07:45 +00:00
Code Issues Activity Actions

LibWeb: Begin adding support for Function IDL types in unions

Browse source 
For example, setTimeout/setInterval use a TimerHandler, which is a union
of (DOMString or Function).
This commit is contained in:
Timothy Flynn 2023-03-14 07:26:42 -04:00 • committed by Tim Flynn
parent 50717ce404
commit 6c5e79ce3a
1 changed files with 20 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Meta/Lagom/Tools/CodeGenerators/LibWeb/BindingsGenerator/IDLGenerators.cpp
View file

@ -145,6 +145,9 @@ CppType idl_type_name_to_cpp_type(Type const& type, Interface const& interface)
if (type.name() == "File") if (type.name() == "File")
return { .name = "JS::Handle<FileAPI::File>", .sequence_storage_type = SequenceStorageType::MarkedVector }; return { .name = "JS::Handle<FileAPI::File>", .sequence_storage_type = SequenceStorageType::MarkedVector };
if (type.name() == "Function")
return { .name = "JS::Handle<WebIDL::CallbackType>", .sequence_storage_type = SequenceStorageType::MarkedVector };
if (type.name() == "sequence") { if (type.name() == "sequence") {
auto& parameterized_type = verify_cast<ParameterizedType>(type); auto& parameterized_type = verify_cast<ParameterizedType>(type);
auto& sequence_type = parameterized_type.parameters().first(); auto& sequence_type = parameterized_type.parameters().first();
@ -1092,9 +1095,23 @@ static void generate_to_cpp(SourceGenerator& generator, ParameterType& parameter
// 1. If types includes a typed array type whose name is the value of V’s [[TypedArrayName]] internal slot, then return the result of converting V to that type. // 1. If types includes a typed array type whose name is the value of V’s [[TypedArrayName]] internal slot, then return the result of converting V to that type.
// 2. If types includes object, then return the IDL value that is a reference to the object V. // 2. If types includes object, then return the IDL value that is a reference to the object V.
// FIXME: 9. If IsCallable(V) is true, then: // 9. If IsCallable(V) is true, then:
// 1. If types includes a callback function type, then return the result of converting V to that callback function type. // 1. If types includes a callback function type, then return the result of converting V to that callback function type.
// 2. If types includes object, then return the IDL value that is a reference to the object V. // 2. If types includes object, then return the IDL value that is a reference to the object V.
bool includes_callable = false;
for (auto const& type : types) {
if (type->name() == "Function"sv) {
includes_callable = true;
break;
}
}
if (includes_callable) {
union_generator.append(R"~~~(
if (@js_name@@js_suffix@_object.is_function())
return JS::make_handle(vm.heap().allocate_without_realm<WebIDL::CallbackType>(@js_name@@js_suffix@.as_function(), HTML::incumbent_settings_object()));
)~~~");
}
// 10. If Type(V) is Object, then: // 10. If Type(V) is Object, then:
// 1. If types includes a sequence type, then: // 1. If types includes a sequence type, then: