RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 04:37:44 +00:00
Code Issues Activity Actions

LibJS: Only allow TimeZone this value in Temporal.TimeZone#id

Browse source 
This is a normative change in the Temporal spec.

See: 2644fc6
This commit is contained in:
Luke Wilde 2021-12-18 23:06:43 +00:00 • committed by Linus Groh
parent 803e96f0c5
commit 6c8c34ed6c
2 changed files with 10 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibJS/Runtime/Temporal/TimeZonePrototype.cpp
View file

@ -48,10 +48,11 @@ void TimeZonePrototype::initialize(GlobalObject& global_object)
JS_DEFINE_NATIVE_FUNCTION(TimeZonePrototype::id_getter)
{
// 1. Let timeZone be the this value.
auto time_zone = vm.this_value(global_object);
// 2. Perform ? RequireInternalSlot(timeZone, [[InitializedTemporalTimeZone]]).
auto* time_zone = TRY(typed_this_object(global_object));
// 2. Return ? ToString(timeZone).
return js_string(vm, TRY(time_zone.to_string(global_object)));
// 3. Return ? ToString(timeZone).
return js_string(vm, TRY(Value(time_zone).to_string(global_object)));
}
// 11.4.4 Temporal.TimeZone.prototype.getOffsetNanosecondsFor ( instant ), https://tc39.es/proposal-temporal/#sec-temporal.timezone.prototype.getoffsetnanosecondsfor

8
Userland/Libraries/LibJS/Tests/builtins/Temporal/TimeZone/TimeZone.prototype.id.js
View file

@ -3,8 +3,12 @@ describe("correct behavior", () => {
const timeZone = new Temporal.TimeZone("UTC");
expect(timeZone.id).toBe("UTC");
});
});
test("works with any this value", () => {
expect(Reflect.get(Temporal.TimeZone.prototype, "id", "foo")).toBe("foo");
describe("errors", () => {
test("this value must be a Temporal.TimeZone object", () => {
expect(() => {
Reflect.get(Temporal.TimeZone.prototype, "id", "foo");
}).toThrowWithMessage(TypeError, "Not an object of type Temporal.TimeZone");
});
});