RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 13:12:46 +00:00
Code Issues Activity Actions

LibJS: Handle "for" statements with empty initializer and updater

Browse source
This commit is contained in:
Andreas Kling 2020-03-25 16:14:18 +01:00
parent 30d24af54a
commit 6c9d2cfa5e
3 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/AST.cpp
View file

@ -126,7 +126,7 @@ Value ForStatement::execute(Interpreter& interpreter) const
{ {
RefPtr<BlockStatement> wrapper; RefPtr<BlockStatement> wrapper;
if (m_init->is_variable_declaration() && static_cast<const VariableDeclaration*>(m_init.ptr())->declaration_type() != DeclarationType::Var) { if (m_init && m_init->is_variable_declaration() && static_cast<const VariableDeclaration*>(m_init.ptr())->declaration_type() != DeclarationType::Var) {
wrapper = create_ast_node<BlockStatement>(); wrapper = create_ast_node<BlockStatement>();
interpreter.enter_scope(*wrapper, {}, ScopeType::Block); interpreter.enter_scope(*wrapper, {}, ScopeType::Block);
} }

2
Libraries/LibJS/Parser.cpp
View file

@ -612,7 +612,7 @@ NonnullRefPtr<ForStatement> Parser::parse_for_statement()
RefPtr<Expression> update; RefPtr<Expression> update;
switch (m_current_token.type()) { switch (m_current_token.type()) {
case TokenType::Semicolon: case TokenType::ParenClose:
break; break;
default: default:
update = parse_expression(0); update = parse_expression(0);

24
Libraries/LibJS/Tests/for-basic.js Normal file
View file

@ -0,0 +1,24 @@
function assert(x) { if (!x) throw 1; }
try {
var a = [];
for (var i = 0; i < 3; ++i) {
a.push(i);
}
assert(a.length === 3);
assert(a[0] === 0);
assert(a[1] === 1);
assert(a[2] === 2);
for (; a.length < 6;) {
a.push('x');
}
assert(a.length === 6);
assert(a[3] === 'x');
assert(a[4] === 'x');
assert(a[5] === 'x');
console.log("PASS");
} catch (e) {
console.log("FAIL: " + e);
}