RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:37:35 +00:00
Code Issues Activity Actions

LibJS: Rename ToPartialDuration to ToTemporalPartialDurationRecord

Browse source 
This is an editorial change in the Temporal spec.

See: 0509d41
This commit is contained in:
Linus Groh 2022-06-14 21:23:01 +01:00
parent 6982e53113
commit 6cc69bbd8e
3 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/Temporal/Duration.cpp
View file

@ -177,8 +177,8 @@ ThrowCompletionOr<DurationRecord> to_temporal_duration_record(GlobalObject& glob
// 3. Let result be a new Duration Record with each field set to 0.
auto result = DurationRecord {};
// 4. Let partial be ? ToPartialDuration(temporalDurationLike).
auto partial = TRY(to_partial_duration(global_object, temporal_duration_like));
// 4. Let partial be ? ToTemporalPartialDurationRecord(temporalDurationLike).
auto partial = TRY(to_temporal_partial_duration_record(global_object, temporal_duration_like));
auto duration_record_fields = temporal_duration_record_fields<DurationRecord, double>(vm);
auto partial_duration_record_fields = temporal_duration_record_fields<PartialDurationRecord, Optional<double>>(vm);
@ -295,8 +295,8 @@ StringView default_temporal_largest_unit(double years, double months, double wee
return "nanosecond"sv;
}
// 7.5.13 ToPartialDuration ( temporalDurationLike ), https://tc39.es/proposal-temporal/#sec-temporal-topartialduration
ThrowCompletionOr<PartialDurationRecord> to_partial_duration(GlobalObject& global_object, Value temporal_duration_like)
// 7.5.13 ToTemporalPartialDurationRecord ( temporalDurationLike ), https://tc39.es/proposal-temporal/#sec-temporal-totemporalpartialdurationrecord
ThrowCompletionOr<PartialDurationRecord> to_temporal_partial_duration_record(GlobalObject& global_object, Value temporal_duration_like)
{
auto& vm = global_object.vm();

2
Userland/Libraries/LibJS/Runtime/Temporal/Duration.h
View file

@ -145,7 +145,7 @@ ThrowCompletionOr<DurationRecord> to_temporal_duration_record(GlobalObject&, Val
i8 duration_sign(double years, double months, double weeks, double days, double hours, double minutes, double seconds, double milliseconds, double microseconds, double nanoseconds);
bool is_valid_duration(double years, double months, double weeks, double days, double hours, double minutes, double seconds, double milliseconds, double microseconds, double nanoseconds);
StringView default_temporal_largest_unit(double years, double months, double weeks, double days, double hours, double minutes, double seconds, double milliseconds, double microseconds);
ThrowCompletionOr<PartialDurationRecord> to_partial_duration(GlobalObject&, Value temporal_duration_like);
ThrowCompletionOr<PartialDurationRecord> to_temporal_partial_duration_record(GlobalObject&, Value temporal_duration_like);
ThrowCompletionOr<Duration*> create_temporal_duration(GlobalObject&, double years, double months, double weeks, double days, double hours, double minutes, double seconds, double milliseconds, double microseconds, double nanoseconds, FunctionObject const* new_target = nullptr);
Duration* create_negated_temporal_duration(GlobalObject& global_object, Duration const& duration);
ThrowCompletionOr<double> calculate_offset_shift(GlobalObject&, Value relative_to_value, double years, double months, double weeks, double days, double hours, double minutes, double seconds, double milliseconds, double microseconds, double nanoseconds);

4
Userland/Libraries/LibJS/Runtime/Temporal/DurationPrototype.cpp
View file

@ -202,8 +202,8 @@ JS_DEFINE_NATIVE_FUNCTION(DurationPrototype::with)
// 2. Perform ? RequireInternalSlot(duration, [[InitializedTemporalDuration]]).
auto* duration = TRY(typed_this_object(global_object));
// 3. Let temporalDurationLike be ? ToPartialDuration(temporalDurationLike).
auto temporal_duration_like = TRY(to_partial_duration(global_object, vm.argument(0)));
// 3. Let temporalDurationLike be ? ToTemporalPartialDurationRecord(temporalDurationLike).
auto temporal_duration_like = TRY(to_temporal_partial_duration_record(global_object, vm.argument(0)));
// 4. If temporalDurationLike.[[Years]] is not undefined, then
// a. Let years be temporalDurationLike.[[Years]].