From 6cd57d4c15e364f8cf9edfaa817eea7a759f3a5f Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Fri, 4 Nov 2022 21:20:46 +0000 Subject: [PATCH] LibWeb: Properly copy method and headers from the input in Request() We were accidentally copying these from the newly created Request object's underlying request, to itself. Thanks to Lubrsi for catching this! Co-authored-by: Luke Wilde --- Userland/Libraries/LibWeb/Fetch/Request.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibWeb/Fetch/Request.cpp b/Userland/Libraries/LibWeb/Fetch/Request.cpp index 8c15539835..ea33c6bfd2 100644 --- a/Userland/Libraries/LibWeb/Fetch/Request.cpp +++ b/Userland/Libraries/LibWeb/Fetch/Request.cpp @@ -174,12 +174,12 @@ WebIDL::ExceptionOr> Request::construct_impl(JS::Realm // method // request’s method. - request->set_method(TRY_OR_RETURN_OOM(realm, ByteBuffer::copy(request->method()))); + request->set_method(TRY_OR_RETURN_OOM(realm, ByteBuffer::copy(input_request->method()))); // header list // A copy of request’s header list. auto header_list_copy = Infrastructure::HeaderList::create(vm); - for (auto& header : *request->header_list()) + for (auto& header : *input_request->header_list()) TRY_OR_RETURN_OOM(realm, header_list_copy->append(header)); request->set_header_list(header_list_copy);