RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:38:11 +00:00
Code Issues Activity Actions

LibWeb: Don't assume grid size is always Function or Token

Browse source 
This stops `grid-template-columns: minmax({},{})` from crashing.
This commit is contained in:
Sam Atkins 2023-11-21 12:02:59 +00:00 • committed by Andreas Kling
parent 1a17b8a304
commit 6cd6186399
3 changed files with 17 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -5030,14 +5030,13 @@ Optional<CSS::GridSize> Parser::parse_grid_size(ComponentValue const& component_
return {};
}
auto token = component_value.token();
if (token.is(Token::Type::Ident) && token.ident().equals_ignoring_ascii_case("auto"sv))
if (component_value.is_ident("auto"sv))
return GridSize::make_auto();
if (token.is(Token::Type::Ident) && token.ident().equals_ignoring_ascii_case("max-content"sv))
if (component_value.is_ident("max-content"sv))
return GridSize(GridSize::Type::MaxContent);
if (token.is(Token::Type::Ident) && token.ident().equals_ignoring_ascii_case("min-content"sv))
if (component_value.is_ident("min-content"sv))
return GridSize(GridSize::Type::MinContent);
auto dimension = parse_dimension(token);
auto dimension = parse_dimension(component_value);
if (!dimension.has_value())
return {};
if (dimension->is_length())