RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 22:37:35 +00:00
Code Issues Activity Actions

LibJS: Implement RegExp.prototype.source according to the spec

Browse source 
RegExp.prototype.source must check if "this" object is the
RegExp.prototype object before raising a TypeError.
This commit is contained in:
Timothy Flynn 2021-07-09 15:01:47 -04:00 • committed by Linus Groh
parent 2f6eec1322
commit 6cd966c1e1
1 changed files with 9 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp
View file

@ -274,19 +274,18 @@ JS_DEFINE_NATIVE_GETTER(RegExpPrototype::flags)
// 22.2.5.12 get RegExp.prototype.source, https://tc39.es/ecma262/#sec-get-regexp.prototype.source
JS_DEFINE_NATIVE_GETTER(RegExpPrototype::source)
{
auto this_object = this_object_from(vm, global_object);
if (!this_object)
return {};
auto* regexp_prototype = global_object.regexp_prototype();
if (this_object == regexp_prototype)
return js_string(vm, "(?:)");
auto regexp_object = regexp_object_from(vm, global_object);
auto* regexp_object = this_object_from(vm, global_object);
if (!regexp_object)
return {};
return js_string(vm, escape_regexp_pattern(*regexp_object));
if (!is<RegExpObject>(regexp_object)) {
if (same_value(regexp_object, global_object.regexp_prototype()))
return js_string(vm, "(?:)");
vm.throw_exception<TypeError>(global_object, ErrorType::NotA, "RegExp");
return {};
}
return js_string(vm, escape_regexp_pattern(static_cast<RegExpObject&>(*regexp_object)));
}
// 22.2.5.2 RegExp.prototype.exec ( string ), https://tc39.es/ecma262/#sec-regexp.prototype.exec