RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:57:35 +00:00
Code Issues Activity Actions

LibJS: Implement $262.evalScript() according to the given algorithm

Browse source 
test262's INTERPRETING.md specifies the exact steps for this function,
so let's shuffle some things around and add "spec" comments.

Most importantly this now returns the result of the evaluated script,
which at least one test relies on:
https://github.com/tc39/test262/blob/main/test/built-ins/Proxy/revocable/tco-fn-realm.js
This commit is contained in:
Linus Groh 2022-08-30 12:00:04 +01:00
parent 69415f0608
commit 6cedb1b9d9
1 changed files with 24 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Userland/Libraries/LibJS/Contrib/Test262/$262Object.cpp
View file

@ -80,12 +80,30 @@ JS_DEFINE_NATIVE_FUNCTION($262Object::detach_array_buffer)
JS_DEFINE_NATIVE_FUNCTION($262Object::eval_script) JS_DEFINE_NATIVE_FUNCTION($262Object::eval_script)
{ {
auto source = TRY(vm.argument(0).to_string(vm)); auto source_text = TRY(vm.argument(0).to_string(vm));
auto script_or_error = Script::parse(source, *vm.current_realm());
if (script_or_error.is_error()) // 1. Let hostDefined be any host-defined values for the provided sourceText (obtained in an implementation dependent manner)
return vm.throw_completion<SyntaxError>(script_or_error.error()[0].to_string());
TRY(vm.interpreter().run(script_or_error.value())); // 2. Let realm be the current Realm Record.
return js_undefined(); auto& realm = *vm.current_realm();
// 3. Let s be ParseScript(sourceText, realm, hostDefined).
auto script_or_error = Script::parse(source_text, realm);
// 4. If s is a List of errors, then
if (script_or_error.is_error()) {
// a. Let error be the first element of s.
auto& error = script_or_error.error()[0];
// b. Return Completion { [[Type]]: throw, [[Value]]: error, [[Target]]: empty }.
return vm.throw_completion<SyntaxError>(error.to_string());
}
// 5. Let status be ScriptEvaluation(s).
auto status = vm.interpreter().run(script_or_error.value());
// 6. Return Completion(status).
return status;
} }
} }