RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 02:47:34 +00:00
Code Issues Activity Actions

LibWeb: Split ResolutionStyleValue out of StyleValue.{h,cpp}

Browse source
This commit is contained in:
Sam Atkins 2023-03-24 17:40:28 +00:00 • committed by Linus Groh
parent b1ccd30b02
commit 6cedf5e05b
4 changed files with 40 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -61,6 +61,7 @@
#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h> #include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
#include <LibWeb/CSS/StyleValues/PositionStyleValue.h> #include <LibWeb/CSS/StyleValues/PositionStyleValue.h>
#include <LibWeb/CSS/StyleValues/RadialGradientStyleValue.h> #include <LibWeb/CSS/StyleValues/RadialGradientStyleValue.h>
#include <LibWeb/CSS/StyleValues/ResolutionStyleValue.h>
#include <LibWeb/DOM/Document.h> #include <LibWeb/DOM/Document.h>
#include <LibWeb/Dump.h> #include <LibWeb/Dump.h>
#include <LibWeb/Infra/Strings.h> #include <LibWeb/Infra/Strings.h>

1
Userland/Libraries/LibWeb/CSS/StyleValue.cpp
View file

@ -44,6 +44,7 @@
#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h> #include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
#include <LibWeb/CSS/StyleValues/PositionStyleValue.h> #include <LibWeb/CSS/StyleValues/PositionStyleValue.h>
#include <LibWeb/CSS/StyleValues/RadialGradientStyleValue.h> #include <LibWeb/CSS/StyleValues/RadialGradientStyleValue.h>
#include <LibWeb/CSS/StyleValues/ResolutionStyleValue.h>
#include <LibWeb/DOM/Document.h> #include <LibWeb/DOM/Document.h>
#include <LibWeb/HTML/BrowsingContext.h> #include <LibWeb/HTML/BrowsingContext.h>
#include <LibWeb/Loader/LoadRequest.h> #include <LibWeb/Loader/LoadRequest.h>

24
Userland/Libraries/LibWeb/CSS/StyleValue.h
View file

@ -627,30 +627,6 @@ private:
NonnullOwnPtr<CalcSum> m_expression; NonnullOwnPtr<CalcSum> m_expression;
}; };
class ResolutionStyleValue : public StyleValueWithDefaultOperators<ResolutionStyleValue> {
public:
static ValueComparingNonnullRefPtr<ResolutionStyleValue> create(Resolution resolution)
{
return adopt_ref(*new ResolutionStyleValue(move(resolution)));
}
virtual ~ResolutionStyleValue() override { }
Resolution const& resolution() const { return m_resolution; }
virtual ErrorOr<String> to_string() const override { return m_resolution.to_string(); }
bool properties_equal(ResolutionStyleValue const& other) const { return m_resolution == other.m_resolution; }
private:
explicit ResolutionStyleValue(Resolution resolution)
: StyleValueWithDefaultOperators(Type::Resolution)
, m_resolution(move(resolution))
{
}
Resolution m_resolution;
};
class ShadowStyleValue final : public StyleValueWithDefaultOperators<ShadowStyleValue> { class ShadowStyleValue final : public StyleValueWithDefaultOperators<ShadowStyleValue> {
public: public:
static ValueComparingNonnullRefPtr<ShadowStyleValue> static ValueComparingNonnullRefPtr<ShadowStyleValue>

38
Userland/Libraries/LibWeb/CSS/StyleValues/ResolutionStyleValue.h Normal file
View file

@ -0,0 +1,38 @@
/*
* Copyright (c) 2022-2023, Sam Atkins <atkinssj@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibWeb/CSS/Resolution.h>
#include <LibWeb/CSS/StyleValue.h>
namespace Web::CSS {
class ResolutionStyleValue : public StyleValueWithDefaultOperators<ResolutionStyleValue> {
public:
static ValueComparingNonnullRefPtr<ResolutionStyleValue> create(Resolution resolution)
{
return adopt_ref(*new ResolutionStyleValue(move(resolution)));
}
virtual ~ResolutionStyleValue() override = default;
Resolution const& resolution() const { return m_resolution; }
virtual ErrorOr<String> to_string() const override { return m_resolution.to_string(); }
bool properties_equal(ResolutionStyleValue const& other) const { return m_resolution == other.m_resolution; }
private:
explicit ResolutionStyleValue(Resolution resolution)
: StyleValueWithDefaultOperators(Type::Resolution)
, m_resolution(move(resolution))
{
}
Resolution m_resolution;
};
}