RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 23:47:45 +00:00
Code Issues Activity Actions

LibWeb: Update Navigable::navigate() to the current state of the spec

Browse source 
A few parameters and step renumberings have happened since we first
implemented this algorithm.
This commit is contained in:
Andrew Kaster 2023-08-28 18:06:10 +02:00 • committed by Alexander Kalenik
parent cf1f14f58c
commit 6cfe19e5be
3 changed files with 294 additions and 112 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Userland/Libraries/LibWeb/HTML/Navigable.h
View file

@ -9,12 +9,16 @@
#include <AK/String.h>
#include <LibJS/Heap/Cell.h>
#include <LibWeb/Bindings/NavigationPrototype.h>
#include <LibWeb/Forward.h>
#include <LibWeb/HTML/ActivateTab.h>
#include <LibWeb/HTML/HistoryHandlingBehavior.h>
#include <LibWeb/HTML/POSTResource.h>
#include <LibWeb/HTML/SandboxingFlagSet.h>
#include <LibWeb/HTML/SourceSnapshotParams.h>
#include <LibWeb/HTML/StructuredSerialize.h>
#include <LibWeb/HTML/TokenizedFeatures.h>
#include <LibWeb/XHR/FormDataEntry.h>
namespace Web::HTML {
@ -23,6 +27,18 @@ enum class CSPNavigationType {
FormSubmission,
};
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#user-navigation-involvement
enum class UserNaviagationInvolvement {
BrowserUI,
Activation,
None,
};
// https://html.spec.whatwg.org/multipage/browsing-the-web.html#target-snapshot-params
struct TargetSnapshotParams {
SandboxingFlagSet sandboxing_flags {};
};
// https://html.spec.whatwg.org/multipage/document-sequences.html#navigable
class Navigable : public JS::Cell {
JS_CELL(Navigable, JS::Cell);
@ -97,9 +113,11 @@ public:
Variant<Empty, String, POSTResource> document_resource = Empty {},
JS::GCPtr<Fetch::Infrastructure::Response> = nullptr,
bool exceptions_enabled = false,
HistoryHandlingBehavior = HistoryHandlingBehavior::Push,
CSPNavigationType csp_navigation_type = CSPNavigationType::Other,
ReferrerPolicy::ReferrerPolicy = ReferrerPolicy::ReferrerPolicy::EmptyString);
Bindings::NavigationHistoryBehavior = Bindings::NavigationHistoryBehavior::Auto,
Optional<SerializationRecord> navigation_api_state = {},
Optional<Vector<XHR::FormDataEntry>&> form_data_entry_list = {},
ReferrerPolicy::ReferrerPolicy = ReferrerPolicy::ReferrerPolicy::EmptyString,
UserNaviagationInvolvement = UserNaviagationInvolvement::None);
WebIDL::ExceptionOr<void> navigate_to_a_fragment(AK::URL const&, HistoryHandlingBehavior, String navigation_id);
@ -116,6 +134,9 @@ protected:
Variant<Empty, Traversal, String> m_ongoing_navigation;
private:
bool allowed_by_sandboxing_to_navigate(Navigable const& target, SourceSnapshotParams const&);
TargetSnapshotParams snapshot_target_snapshot_params();
// https://html.spec.whatwg.org/multipage/document-sequences.html#nav-id
String m_id;
@ -139,5 +160,6 @@ private:
};
bool navigation_must_be_a_replace(AK::URL const& url, DOM::Document const& document);
void finalize_a_cross_document_navigation(JS::NonnullGCPtr<Navigable>, HistoryHandlingBehavior, JS::NonnullGCPtr<SessionHistoryEntry>);
}