RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:38:11 +00:00
Code Issues Activity Actions

LibCore: Turns some heap-allocated events into stack-allocated ones

Browse source
This commit is contained in:
Andreas Kling 2020-07-16 20:44:21 +02:00
parent 869a3e2cf3
commit 6d27915f4b
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibCore/Object.cpp
View file

@ -89,7 +89,8 @@ void Object::add_child(Object& object)
ASSERT(!object.parent() || object.parent() == this);
object.m_parent = this;
m_children.append(object);
event(*make<Core::ChildEvent>(Core::Event::ChildAdded, object));
Core::ChildEvent child_event(Core::Event::ChildAdded, object);
event(child_event);
}
void Object::insert_child_before(Object& new_child, Object& before_child)
@ -98,7 +99,8 @@ void Object::insert_child_before(Object& new_child, Object& before_child)
ASSERT(!new_child.parent() || new_child.parent() == this);
new_child.m_parent = this;
m_children.insert_before_matching(new_child, [&](auto& existing_child) { return existing_child.ptr() == &before_child; });
event(*make<Core::ChildEvent>(Core::Event::ChildAdded, new_child, &before_child));
Core::ChildEvent child_event(Core::Event::ChildAdded, new_child, &before_child);
event(child_event);
}
void Object::remove_child(Object& object)
@ -109,7 +111,8 @@ void Object::remove_child(Object& object)
NonnullRefPtr<Object> protector = object;
object.m_parent = nullptr;
m_children.remove(i);
event(*make<Core::ChildEvent>(Core::Event::ChildRemoved, object));
Core::ChildEvent child_event(Core::Event::ChildRemoved, object);
event(child_event);
return;
}
}