RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:27:34 +00:00
Code Issues Activity Actions

LibJS: Fix Array.prototype.indexOf fromIndex negative

Browse source 
If negative fromIndex considers displacement from the end of the array
without decreasing 1 of de size.
This commit is contained in:
Kesse Jones 2020-04-22 08:45:26 -03:00 • committed by Andreas Kling
parent edd8abc4cf
commit 6d308113b8
2 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Runtime/ArrayPrototype.cpp
View file

@ -321,7 +321,7 @@ Value ArrayPrototype::index_of(Interpreter& interpreter)
if (from_index < negative_min_index)
from_index = 0;
else if (from_index < 0)
from_index = (array_size - 1) + from_index;
from_index = array_size + from_index;
}
auto search_element = interpreter.argument(0);

3
Libraries/LibJS/Tests/Array.prototype.indexOf.js
View file

@ -14,6 +14,9 @@ try {
assert(array.indexOf(1, 1000) === -1);
assert(array.indexOf(1, -1000) === 2);
assert(array.indexOf('serenity') === -1);
assert(array.indexOf(false, -1) === 4);
assert(array.indexOf(2, -1) === -1);
assert(array.indexOf(2, -2) === 3);
assert([].indexOf('serenity') === -1);
assert([].indexOf('serenity', 10) === -1);
assert([].indexOf('serenity', -10) === -1);