RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 19:12:43 +00:00
Code Issues Activity Actions

LibWeb: Fix logic issue when parsing CSS custom properties

Browse source 
With best wishes from De Morgan, this is the correct way to check
whether the string isn't of the form "var(...)".
This commit is contained in:
Tobias Christiansen 2021-06-09 21:31:13 +02:00 • committed by Andreas Kling
parent b54bfdd696
commit 6d3361f077
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/CSS/Parser/DeprecatedCSSParser.cpp
View file

@ -219,7 +219,7 @@ static bool takes_integer_value(CSS::PropertyID property_id)
static StringView parse_custom_property_name(const StringView& value)
{
if (!value.starts_with("var(") && !value.ends_with(")"))
if (!value.starts_with("var(") || !value.ends_with(")"))
return {};
// FIXME: Allow for fallback
auto first_comma_index = value.find_first_of(",");