RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 19:58:11 +00:00
Code Issues Activity Actions

LibWeb: Use single shared instance of Inherit/InitialStyleValue

Browse source 
These are always the same, so we can avoid allocating them repeatedly
and just use a single instance of each. :^)
This commit is contained in:
Sam Atkins 2021-08-20 12:08:53 +01:00 • committed by Andreas Kling
parent d2342caf42
commit 6d39f4342d
2 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -1404,9 +1404,9 @@ RefPtr<StyleValue> Parser::parse_builtin_value(ParsingContext const&, StyleCompo
if (component_value.is(Token::Type::Ident)) {
auto ident = component_value.token().ident();
if (ident.equals_ignoring_case("inherit"))
return InheritStyleValue::create();
return InheritStyleValue::the();
if (ident.equals_ignoring_case("initial"))
return InitialStyleValue::create();
return InitialStyleValue::the();
// FIXME: Implement `unset` keyword
}
@ -2738,7 +2738,7 @@ RefPtr<StyleValue> Parser::parse_text_decoration_value(ParsingContext const& con
decoration_style = IdentifierStyleValue::create(ValueID::Solid);
// FIXME: Should default to 'currentcolor' special value: https://www.w3.org/TR/css-color-3/#currentcolor
if (!decoration_color)
decoration_color = InitialStyleValue::create();
decoration_color = InitialStyleValue::the();
return TextDecorationStyleValue::create(decoration_line.release_nonnull(), decoration_style.release_nonnull(), decoration_color.release_nonnull());
}