RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 00:57:44 +00:00
Code Issues Activity Actions

LibDebug+Everywhere: Avoid void* -> FlatPtr -> void* dance

Browse source 
And limit the `void*` to the functions that interface the system (i.e.
ptrace wrappers).
This generally makes the code less riddled with casts.
This commit is contained in:
Ali Mohammad Pur 2022-01-27 04:46:27 +03:30 • committed by Linus Groh
parent b27b22a68c
commit 6d64b13a1b
15 changed files with 97 additions and 96 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibCoredump/Inspector.cpp
View file

@ -51,11 +51,11 @@ void Inspector::parse_loaded_libraries(Function<void(float)> on_progress)
});
}
bool Inspector::poke(void*, FlatPtr) { return false; }
bool Inspector::poke(FlatPtr, FlatPtr) { return false; }
Optional<FlatPtr> Inspector::peek(void* address) const
Optional<FlatPtr> Inspector::peek(FlatPtr address) const
{
return m_reader->peek_memory((FlatPtr)address);
return m_reader->peek_memory(address);
}
PtraceRegisters Inspector::get_registers() const

4
Userland/Libraries/LibCoredump/Inspector.h
View file

@ -21,8 +21,8 @@ public:
virtual ~Inspector() override = default;
// ^Debug::ProcessInspector
virtual bool poke(void* address, FlatPtr data) override;
virtual Optional<FlatPtr> peek(void* address) const override;
virtual bool poke(FlatPtr address, FlatPtr data) override;
virtual Optional<FlatPtr> peek(FlatPtr address) const override;
virtual PtraceRegisters get_registers() const override;
virtual void set_registers(PtraceRegisters const&) override;
virtual void for_each_loaded_library(Function<IterationDecision(Debug::LoadedLibrary const&)>) const override;