mirror of
https://github.com/RGBCube/serenity
synced 2025-07-24 21:37:34 +00:00
LibJS: Implement bytecode ops for logical expressions
This commit is contained in:
parent
216d27d4c1
commit
6da587b59b
5 changed files with 83 additions and 0 deletions
|
@ -557,6 +557,7 @@ public:
|
|||
|
||||
virtual Value execute(Interpreter&, GlobalObject&) const override;
|
||||
virtual void dump(int indent) const override;
|
||||
virtual Optional<Bytecode::Register> generate_bytecode(Bytecode::Generator&) const override;
|
||||
|
||||
private:
|
||||
LogicalOp m_op;
|
||||
|
|
|
@ -121,6 +121,53 @@ Optional<Bytecode::Register> BinaryExpression::generate_bytecode(Bytecode::Gener
|
|||
}
|
||||
}
|
||||
|
||||
Optional<Bytecode::Register> LogicalExpression::generate_bytecode(Bytecode::Generator& generator) const
|
||||
{
|
||||
auto result_reg = generator.allocate_register();
|
||||
auto lhs_reg = m_lhs->generate_bytecode(generator);
|
||||
|
||||
Bytecode::Instruction* test_instr;
|
||||
switch (m_op) {
|
||||
case LogicalOp::And:
|
||||
test_instr = &generator.emit<Bytecode::Op::JumpIfTrue>(*lhs_reg);
|
||||
break;
|
||||
case LogicalOp::Or:
|
||||
test_instr = &generator.emit<Bytecode::Op::JumpIfFalse>(*lhs_reg);
|
||||
break;
|
||||
case LogicalOp::NullishCoalescing:
|
||||
test_instr = &generator.emit<Bytecode::Op::JumpIfNullish>(*lhs_reg);
|
||||
break;
|
||||
default:
|
||||
VERIFY_NOT_REACHED();
|
||||
}
|
||||
|
||||
generator.emit<Bytecode::Op::LoadRegister>(result_reg, *lhs_reg);
|
||||
auto& end_jump = generator.emit<Bytecode::Op::Jump>();
|
||||
|
||||
auto rhs_label = generator.make_label();
|
||||
|
||||
switch (m_op) {
|
||||
case LogicalOp::And:
|
||||
static_cast<Bytecode::Op::JumpIfTrue*>(test_instr)->set_target(rhs_label);
|
||||
break;
|
||||
case LogicalOp::Or:
|
||||
static_cast<Bytecode::Op::JumpIfFalse*>(test_instr)->set_target(rhs_label);
|
||||
break;
|
||||
case LogicalOp::NullishCoalescing:
|
||||
static_cast<Bytecode::Op::JumpIfNullish*>(test_instr)->set_target(rhs_label);
|
||||
break;
|
||||
default:
|
||||
VERIFY_NOT_REACHED();
|
||||
}
|
||||
|
||||
auto rhs_reg = m_rhs->generate_bytecode(generator);
|
||||
generator.emit<Bytecode::Op::LoadRegister>(result_reg, *rhs_reg);
|
||||
|
||||
end_jump.set_target(generator.make_label());
|
||||
|
||||
return result_reg;
|
||||
}
|
||||
|
||||
Optional<Bytecode::Register> UnaryExpression::generate_bytecode(Bytecode::Generator& generator) const
|
||||
{
|
||||
auto lhs_reg = m_lhs->generate_bytecode(generator);
|
||||
|
|
|
@ -35,6 +35,7 @@
|
|||
O(Jump) \
|
||||
O(JumpIfFalse) \
|
||||
O(JumpIfTrue) \
|
||||
O(JumpIfNullish) \
|
||||
O(Call) \
|
||||
O(EnterScope) \
|
||||
O(Return) \
|
||||
|
|
|
@ -165,6 +165,14 @@ void JumpIfTrue::execute(Bytecode::Interpreter& interpreter) const
|
|||
interpreter.jump(m_target.value());
|
||||
}
|
||||
|
||||
void JumpIfNullish::execute(Bytecode::Interpreter& interpreter) const
|
||||
{
|
||||
VERIFY(m_target.has_value());
|
||||
auto result = interpreter.reg(m_result);
|
||||
if (result.is_nullish())
|
||||
interpreter.jump(m_target.value());
|
||||
}
|
||||
|
||||
void Call::execute(Bytecode::Interpreter& interpreter) const
|
||||
{
|
||||
auto callee = interpreter.reg(m_callee);
|
||||
|
@ -272,6 +280,13 @@ String JumpIfTrue::to_string() const
|
|||
return String::formatted("JumpIfTrue result:{}, target:<empty>", m_result);
|
||||
}
|
||||
|
||||
String JumpIfNullish::to_string() const
|
||||
{
|
||||
if (m_target.has_value())
|
||||
return String::formatted("JumpIfNullish result:{}, target:{}", m_result, m_target.value());
|
||||
return String::formatted("JumpIfNullish result:{}, target:<empty>", m_result);
|
||||
}
|
||||
|
||||
String Call::to_string() const
|
||||
{
|
||||
StringBuilder builder;
|
||||
|
|
|
@ -284,6 +284,25 @@ private:
|
|||
Optional<Label> m_target;
|
||||
};
|
||||
|
||||
class JumpIfNullish final : public Instruction {
|
||||
public:
|
||||
explicit JumpIfNullish(Register result, Optional<Label> target = {})
|
||||
: Instruction(Type::JumpIfNullish)
|
||||
, m_result(result)
|
||||
, m_target(move(target))
|
||||
{
|
||||
}
|
||||
|
||||
void set_target(Optional<Label> target) { m_target = move(target); }
|
||||
|
||||
void execute(Bytecode::Interpreter&) const;
|
||||
String to_string() const;
|
||||
|
||||
private:
|
||||
Register m_result;
|
||||
Optional<Label> m_target;
|
||||
};
|
||||
|
||||
// NOTE: This instruction is variable-width depending on the number of arguments!
|
||||
class Call final : public Instruction {
|
||||
public:
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue