RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 05:37:34 +00:00
Code Issues Activity Actions

LibWeb: Fix integer overflow in gradient painting

Browse source 
This would cause rendering glitches at the edges of gradients (at
certain angles).
This commit is contained in:
MacDue 2022-12-02 13:16:12 +00:00 • committed by Linus Groh
parent 40e978df85
commit 6dbe7b06b3
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/Painting/GradientPainting.cpp
View file

@ -220,19 +220,19 @@ public:
} }
} }
Gfx::Color get_color(uint64_t index) const Gfx::Color get_color(i64 index) const
{ {
return m_gradient_line_colors[clamp(index, 0, m_gradient_line_colors.size() - 1)]; return m_gradient_line_colors[clamp(index, 0, m_gradient_line_colors.size() - 1)];
} }
Gfx::Color sample_color(float loc) const Gfx::Color sample_color(float loc) const
{ {
auto repeat_wrap_if_required = [&](uint64_t loc) { auto repeat_wrap_if_required = [&](i64 loc) {
if (m_repeating) if (m_repeating)
return (loc + m_start_offset) % m_gradient_line_colors.size(); return (loc + m_start_offset) % static_cast<i64>(m_gradient_line_colors.size());
return loc; return loc;
}; };
auto int_loc = static_cast<uint64_t>(floor(loc)); auto int_loc = static_cast<i64>(floor(loc));
auto blend = loc - int_loc; auto blend = loc - int_loc;
auto color = get_color(repeat_wrap_if_required(int_loc)); auto color = get_color(repeat_wrap_if_required(int_loc));
// Blend between the two neighbouring colors (this fixes some nasty aliasing issues at small angles) // Blend between the two neighbouring colors (this fixes some nasty aliasing issues at small angles)