mirror of
https://github.com/RGBCube/serenity
synced 2025-05-31 07:08:10 +00:00
Streams: Consistent behaviour when reading from stream with error.
The streaming operator doesn't short-circuit, consider the following snippet: void foo(InputStream& stream) { int a, b; stream >> a >> b; } If the first read fails, the second is called regardless. It should be well defined what happens in this case: nothing.
This commit is contained in:
parent
5d85be7ed4
commit
6de63782c7
8 changed files with 24 additions and 3 deletions
|
@ -68,6 +68,9 @@ GzipDecompressor::~GzipDecompressor()
|
|||
// FIXME: Again, there are surely a ton of bugs because the code doesn't check for read errors.
|
||||
size_t GzipDecompressor::read(Bytes bytes)
|
||||
{
|
||||
if (has_any_error())
|
||||
return 0;
|
||||
|
||||
if (m_current_member.has_value()) {
|
||||
size_t nread = current_member().m_stream.read(bytes);
|
||||
current_member().m_checksum.update(bytes.trim(nread));
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue