RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 21:07:34 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibCore/TestLibCoreArgsParser.cpp
View file

@ -12,7 +12,7 @@
class ParserResult {
public:
ParserResult(Vector<String> const& arguments)
ParserResult(Vector<DeprecatedString> const& arguments)
{
argv = new char*[arguments.size() + 1];
argc = 0;
@ -60,7 +60,7 @@ public:
size_t argc { 0 };
};
static ParserResult run_parser(Vector<String> arguments, Function<void(Core::ArgsParser&)> parser_initialization = {})
static ParserResult run_parser(Vector<DeprecatedString> arguments, Function<void(Core::ArgsParser&)> parser_initialization = {})
{
Core::ArgsParser parser;
if (parser_initialization)
@ -139,7 +139,7 @@ TEST_CASE(bool_option)
TEST_CASE(positional_string_argument)
{
// Single required string argument
String name = "";
DeprecatedString name = "";
auto parser_result = run_parser({ "app", "buggie" }, [&](auto& parser) {
parser.add_positional_argument(name, "name", "name", Core::ArgsParser::Required::Yes);
});

4
Tests/LibCore/TestLibCoreIODevice.cpp
View file

@ -8,7 +8,7 @@
#include <LibTest/TestCase.h>
#include <unistd.h>
static bool files_have_same_contents(String filename1, String filename2)
static bool files_have_same_contents(DeprecatedString filename1, DeprecatedString filename2)
{
auto file1 = Core::File::open(filename1, Core::OpenMode::ReadOnly).value();
auto file2 = Core::File::open(filename2, Core::OpenMode::ReadOnly).value();
@ -40,7 +40,7 @@ TEST_CASE(file_readline)
TEST_CASE(file_get_read_position)
{
const String path = "10kb.txt";
const DeprecatedString path = "10kb.txt";
auto file = Core::File::open(path, Core::OpenMode::ReadOnly).release_value();
const size_t step_size = 98;