RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 09:47:35 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Applications/Escalator/EscalatorWindow.cpp
View file

@ -36,9 +36,9 @@ EscalatorWindow::EscalatorWindow(StringView executable, Vector<StringView> argum
RefPtr<GUI::Label> app_label = *main_widget.find_descendant_of_type_named<GUI::Label>("description");
String prompt;
DeprecatedString prompt;
if (options.description.is_empty())
prompt = String::formatted("{} requires root access. Please enter password for user \"{}\".", m_arguments[0], m_current_user.username());
prompt = DeprecatedString::formatted("{} requires root access. Please enter password for user \"{}\".", m_arguments[0], m_current_user.username());
else
prompt = options.description;
@ -51,7 +51,7 @@ EscalatorWindow::EscalatorWindow(StringView executable, Vector<StringView> argum
m_ok_button->on_click = [this](auto) {
auto result = check_password();
if (result.is_error()) {
GUI::MessageBox::show_error(this, String::formatted("Failed to execute command: {}", result.error()));
GUI::MessageBox::show_error(this, DeprecatedString::formatted("Failed to execute command: {}", result.error()));
close();
}
};
@ -67,7 +67,7 @@ EscalatorWindow::EscalatorWindow(StringView executable, Vector<StringView> argum
ErrorOr<void> EscalatorWindow::check_password()
{
String password = m_password_input->text();
DeprecatedString password = m_password_input->text();
if (password.is_empty()) {
GUI::MessageBox::show_error(this, "Please enter a password."sv);
return {};

2
Userland/Applications/Escalator/EscalatorWindow.h
View file

@ -7,7 +7,7 @@
#pragma once
#include <AK/String.h>
#include <AK/DeprecatedString.h>
#include <AK/StringView.h>
#include <AK/Vector.h>
#include <LibCore/Account.h>

4
Userland/Applications/Escalator/main.cpp
View file

@ -6,7 +6,7 @@
*/
#include "EscalatorWindow.h"
#include <AK/String.h>
#include <AK/DeprecatedString.h>
#include <LibCore/Account.h>
#include <LibCore/ArgsParser.h>
#include <LibCore/File.h>
@ -35,7 +35,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
auto executable_path = Core::File::resolve_executable_from_environment(command[0]);
if (!executable_path.has_value()) {
GUI::MessageBox::show_error(nullptr, String::formatted("Could not execute command {}: Command not found.", command[0]));
GUI::MessageBox::show_error(nullptr, DeprecatedString::formatted("Could not execute command {}: Command not found.", command[0]));
return 127;
}