RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 10:28:10 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Applications/Help/ManualModel.cpp
View file

@ -46,7 +46,7 @@ Optional<GUI::ModelIndex> ManualModel::index_from_path(StringView path) const
return {};
}
String ManualModel::page_name(const GUI::ModelIndex& index) const
DeprecatedString ManualModel::page_name(const GUI::ModelIndex& index) const
{
if (!index.is_valid())
return {};
@ -57,7 +57,7 @@ String ManualModel::page_name(const GUI::ModelIndex& index) const
return page->name();
}
String ManualModel::page_path(const GUI::ModelIndex& index) const
DeprecatedString ManualModel::page_path(const GUI::ModelIndex& index) const
{
if (!index.is_valid())
return {};
@ -68,7 +68,7 @@ String ManualModel::page_path(const GUI::ModelIndex& index) const
return page->path();
}
ErrorOr<StringView> ManualModel::page_view(String const& path) const
ErrorOr<StringView> ManualModel::page_view(DeprecatedString const& path) const
{
if (path.is_empty())
return StringView {};
@ -87,7 +87,7 @@ ErrorOr<StringView> ManualModel::page_view(String const& path) const
return view;
}
String ManualModel::page_and_section(const GUI::ModelIndex& index) const
DeprecatedString ManualModel::page_and_section(const GUI::ModelIndex& index) const
{
if (!index.is_valid())
return {};
@ -96,7 +96,7 @@ String ManualModel::page_and_section(const GUI::ModelIndex& index) const
return {};
auto* page = static_cast<ManualPageNode const*>(node);
auto* section = static_cast<ManualSectionNode const*>(page->parent());
return String::formatted("{}({})", page->name(), section->section_name());
return DeprecatedString::formatted("{}({})", page->name(), section->section_name());
}
GUI::ModelIndex ManualModel::index(int row, int column, const GUI::ModelIndex& parent_index) const
@ -151,7 +151,7 @@ GUI::Variant ManualModel::data(const GUI::ModelIndex& index, GUI::ModelRole role
case GUI::ModelRole::Search:
if (!node->is_page())
return {};
return String(page_view(page_path(index)).value());
return DeprecatedString(page_view(page_path(index)).value());
case GUI::ModelRole::Display:
return node->name();
case GUI::ModelRole::Icon: