RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 03:27:34 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Applications/HexEditor/FindDialog.h
View file

@ -19,12 +19,12 @@ class FindDialog : public GUI::Dialog {
C_OBJECT(FindDialog);
public:
static ExecResult show(GUI::Window* parent_window, String& out_tex, ByteBuffer& out_buffer, bool& find_all);
static ExecResult show(GUI::Window* parent_window, DeprecatedString& out_tex, ByteBuffer& out_buffer, bool& find_all);
private:
Result<ByteBuffer, String> process_input(String text_value, OptionId opt);
Result<ByteBuffer, DeprecatedString> process_input(DeprecatedString text_value, OptionId opt);
String text_value() const { return m_text_value; }
DeprecatedString text_value() const { return m_text_value; }
OptionId selected_option() const { return m_selected_option; }
bool find_all() const { return m_find_all; }
@ -37,6 +37,6 @@ private:
RefPtr<GUI::Button> m_cancel_button;
bool m_find_all { false };
String m_text_value;
DeprecatedString m_text_value;
OptionId m_selected_option { OPTION_INVALID };
};