RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 09:17:45 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/MailSettings/MailSettingsWidget.cpp
View file

@ -53,7 +53,7 @@ MailSettingsWidget::MailSettingsWidget()
m_port_combobox = *find_descendant_of_type_named<GUI::ComboBox>("port_input");
m_port_combobox->set_text(Config::read_string("Mail"sv, "Connection"sv, "Port"sv, "993"sv));
m_port_combobox->set_only_allow_values_from_model(false);
m_port_combobox->set_model(*GUI::ItemListModel<String>::create(m_common_ports));
m_port_combobox->set_model(*GUI::ItemListModel<DeprecatedString>::create(m_common_ports));
m_port_combobox->on_change = [&](auto, auto) {
set_modified(true);
};

8
Userland/Applications/MailSettings/MailSettingsWidget.h
View file

@ -21,11 +21,11 @@ public:
private:
MailSettingsWidget();
String m_server;
String m_port;
DeprecatedString m_server;
DeprecatedString m_port;
bool m_tls { false };
String m_email;
Vector<String> m_common_ports;
DeprecatedString m_email;
Vector<DeprecatedString> m_common_ports;
RefPtr<GUI::TextBox> m_server_inputbox;
RefPtr<GUI::ComboBox> m_port_combobox;