RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 15:27:35 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/PDFViewer/NumericInput.cpp
View file

@ -70,7 +70,7 @@ void NumericInput::set_max_number(i32 number)
void NumericInput::on_focus_lost()
{
if (m_needs_text_reset) {
set_text(String::number(m_current_number));
set_text(DeprecatedString::number(m_current_number));
m_needs_text_reset = false;
}
if (on_number_changed)
@ -83,7 +83,7 @@ void NumericInput::set_current_number(i32 number, GUI::AllowCallback allow_callb
return;
m_current_number = clamp(number, m_min_number, m_max_number);
set_text(String::number(m_current_number));
set_text(DeprecatedString::number(m_current_number));
if (on_number_changed && allow_callback == GUI::AllowCallback::Yes)
on_number_changed(m_current_number);
}

4
Userland/Applications/PDFViewer/PDFViewerWidget.cpp
View file

@ -184,7 +184,7 @@ void PDFViewerWidget::initialize_toolbar(GUI::Toolbar& toolbar)
void PDFViewerWidget::open_file(Core::File& file)
{
window()->set_title(String::formatted("{} - PDF Viewer", file.filename()));
window()->set_title(DeprecatedString::formatted("{} - PDF Viewer", file.filename()));
auto handle_error = [&]<typename T>(PDF::PDFErrorOr<T> maybe_error) {
if (maybe_error.is_error()) {
@ -214,7 +214,7 @@ void PDFViewerWidget::open_file(Core::File& file)
if (handle_error(m_viewer->set_document(document)))
return;
m_total_page_label->set_text(String::formatted("of {}", document->get_page_count()));
m_total_page_label->set_text(DeprecatedString::formatted("of {}", document->get_page_count()));
m_page_text_box->set_enabled(true);
m_page_text_box->set_current_number(1, GUI::AllowCallback::No);