RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:27:44 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/Spreadsheet/Cell.cpp
View file

@ -11,7 +11,7 @@
namespace Spreadsheet {
void Cell::set_data(String new_data)
void Cell::set_data(DeprecatedString new_data)
{
// If we are a formula, we do not save the beginning '=', if the new_data is "" we can simply change our kind
if (m_kind == Formula && m_data.is_empty() && new_data.is_empty()) {
@ -80,7 +80,7 @@ CellType const& Cell::type() const
return *CellType::get_by_name("Identity"sv);
}
JS::ThrowCompletionOr<String> Cell::typed_display() const
JS::ThrowCompletionOr<DeprecatedString> Cell::typed_display() const
{
return type().display(const_cast<Cell&>(*this), m_type_metadata);
}
@ -156,7 +156,7 @@ JS::Value Cell::js_data()
return JS::js_string(m_sheet->interpreter().heap(), m_data);
}
String Cell::source() const
DeprecatedString Cell::source() const
{
StringBuilder builder;
if (m_kind == Formula)