RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:47:44 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Demos/ModelGallery/BasicModel.cpp
View file

@ -46,7 +46,7 @@ GUI::ModelIndex BasicModel::index(int row, int column, GUI::ModelIndex const& pa
return create_index(row, column);
}
void BasicModel::add_item(String const& item)
void BasicModel::add_item(DeprecatedString const& item)
{
begin_insert_rows({}, m_items.size(), m_items.size());
m_items.append(item);

6
Userland/Demos/ModelGallery/BasicModel.h
View file

@ -20,7 +20,7 @@ public:
virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override { return m_items.size(); }
virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override { return 1; }
virtual String column_name(int) const override { return "Item"; }
virtual DeprecatedString column_name(int) const override { return "Item"; }
virtual GUI::Variant data(GUI::ModelIndex const&, GUI::ModelRole = GUI::ModelRole::Display) const override;
virtual TriState data_matches(GUI::ModelIndex const&, GUI::Variant const&) const override;
@ -29,7 +29,7 @@ public:
Function<void()> on_invalidate;
void add_item(String const& item);
void add_item(DeprecatedString const& item);
void remove_item(GUI::ModelIndex const&);
private:
@ -37,5 +37,5 @@ private:
{
}
Vector<String> m_items;
Vector<DeprecatedString> m_items;
};

4
Userland/Demos/ModelGallery/GalleryWidget.cpp
View file

@ -34,10 +34,10 @@ ErrorOr<void> GalleryWidget::load_basic_model_tab()
m_basic_model->on_invalidate = [&] {
m_invalidation_count++;
m_statusbar->set_text(String::formatted("Times invalidated: {}", m_invalidation_count));
m_statusbar->set_text(DeprecatedString::formatted("Times invalidated: {}", m_invalidation_count));
};
m_statusbar->set_text(String::formatted("Times invalidated: {}", m_invalidation_count));
m_statusbar->set_text(DeprecatedString::formatted("Times invalidated: {}", m_invalidation_count));
m_basic_model->add_item("Well...");
m_basic_model->add_item("...hello...");