RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:17:44 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Cookie/Cookie.h
View file

@ -6,7 +6,7 @@
#pragma once
#include <AK/String.h>
#include <AK/DeprecatedString.h>
#include <LibCore/DateTime.h>
#include <LibIPC/Forward.h>
@ -25,14 +25,14 @@ enum class Source {
};
struct Cookie {
String name;
String value;
DeprecatedString name;
DeprecatedString value;
SameSite same_site;
Core::DateTime creation_time {};
Core::DateTime last_access_time {};
Core::DateTime expiry_time {};
String domain {};
String path {};
DeprecatedString domain {};
DeprecatedString path {};
bool secure { false };
bool http_only { false };
bool host_only { false };

4
Userland/Libraries/LibWeb/Cookie/ParsedCookie.cpp
View file

@ -28,7 +28,7 @@ static void on_http_only_attribute(ParsedCookie& parsed_cookie);
static void on_same_site_attribute(ParsedCookie& parsed_cookie, StringView attribute_value);
static Optional<Core::DateTime> parse_date_time(StringView date_string);
Optional<ParsedCookie> parse_cookie(String const& cookie_string)
Optional<ParsedCookie> parse_cookie(DeprecatedString const& cookie_string)
{
// https://tools.ietf.org/html/rfc6265#section-5.2
@ -197,7 +197,7 @@ void on_domain_attribute(ParsedCookie& parsed_cookie, StringView attribute_value
}
// Convert the cookie-domain to lower case.
parsed_cookie.domain = String(cookie_domain).to_lowercase();
parsed_cookie.domain = DeprecatedString(cookie_domain).to_lowercase();
}
void on_path_attribute(ParsedCookie& parsed_cookie, StringView attribute_value)

12
Userland/Libraries/LibWeb/Cookie/ParsedCookie.h
View file

@ -6,8 +6,8 @@
#pragma once
#include <AK/DeprecatedString.h>
#include <AK/Optional.h>
#include <AK/String.h>
#include <LibCore/DateTime.h>
#include <LibIPC/Forward.h>
#include <LibWeb/Cookie/Cookie.h>
@ -15,18 +15,18 @@
namespace Web::Cookie {
struct ParsedCookie {
String name;
String value;
DeprecatedString name;
DeprecatedString value;
SameSite same_site_attribute { SameSite::Default };
Optional<Core::DateTime> expiry_time_from_expires_attribute {};
Optional<Core::DateTime> expiry_time_from_max_age_attribute {};
Optional<String> domain {};
Optional<String> path {};
Optional<DeprecatedString> domain {};
Optional<DeprecatedString> path {};
bool secure_attribute_present { false };
bool http_only_attribute_present { false };
};
Optional<ParsedCookie> parse_cookie(String const& cookie_string);
Optional<ParsedCookie> parse_cookie(DeprecatedString const& cookie_string);
}