RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:07:36 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Encoding/TextDecoder.cpp
View file

@ -16,7 +16,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<TextDecoder>> TextDecoder::construct_impl(J
{
auto decoder = TextCodec::decoder_for(encoding);
if (!decoder)
return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, String::formatted("Invalid encoding {}", encoding) };
return WebIDL::SimpleException { WebIDL::SimpleExceptionType::TypeError, DeprecatedString::formatted("Invalid encoding {}", encoding) };
return JS::NonnullGCPtr(*realm.heap().allocate<TextDecoder>(realm, realm, *decoder, move(encoding), false, false));
}
@ -35,7 +35,7 @@ TextDecoder::TextDecoder(JS::Realm& realm, TextCodec::Decoder& decoder, FlyStrin
TextDecoder::~TextDecoder() = default;
// https://encoding.spec.whatwg.org/#dom-textdecoder-decode
WebIDL::ExceptionOr<String> TextDecoder::decode(JS::Handle<JS::Object> const& input) const
WebIDL::ExceptionOr<DeprecatedString> TextDecoder::decode(JS::Handle<JS::Object> const& input) const
{
// FIXME: Implement the streaming stuff.

2
Userland/Libraries/LibWeb/Encoding/TextDecoder.h
View file

@ -25,7 +25,7 @@ public:
virtual ~TextDecoder() override;
WebIDL::ExceptionOr<String> decode(JS::Handle<JS::Object> const&) const;
WebIDL::ExceptionOr<DeprecatedString> decode(JS::Handle<JS::Object> const&) const;
FlyString const& encoding() const { return m_encoding; }
bool fatal() const { return m_fatal; }

4
Userland/Libraries/LibWeb/Encoding/TextEncoder.cpp
View file

@ -25,9 +25,9 @@ TextEncoder::TextEncoder(JS::Realm& realm)
TextEncoder::~TextEncoder() = default;
// https://encoding.spec.whatwg.org/#dom-textencoder-encode
JS::Uint8Array* TextEncoder::encode(String const& input) const
JS::Uint8Array* TextEncoder::encode(DeprecatedString const& input) const
{
// NOTE: The AK::String returned from PrimitiveString::string() is always UTF-8, regardless of the internal string type, so most of these steps are no-ops.
// NOTE: The AK::DeprecatedString returned from PrimitiveString::string() is always UTF-8, regardless of the internal string type, so most of these steps are no-ops.
// 1. Convert input to an I/O queue of scalar values.
// 2. Let output be the I/O queue of bytes « end-of-queue ».

2
Userland/Libraries/LibWeb/Encoding/TextEncoder.h
View file

@ -24,7 +24,7 @@ public:
virtual ~TextEncoder() override;
JS::Uint8Array* encode(String const& input) const;
JS::Uint8Array* encode(DeprecatedString const& input) const;
static FlyString const& encoding();