RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 04:07:45 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Selection/Selection.cpp
View file

@ -99,7 +99,7 @@ unsigned Selection::range_count() const
return 0;
}
String Selection::type() const
DeprecatedString Selection::type() const
{
if (!m_range)
return "None";
@ -329,12 +329,12 @@ bool Selection::contains_node(JS::NonnullGCPtr<DOM::Node> node, bool allow_parti
&& (end_relative_position == DOM::RelativeBoundaryPointPosition::Equal || end_relative_position == DOM::RelativeBoundaryPointPosition::After);
}
String Selection::to_string() const
DeprecatedString Selection::to_string() const
{
// FIXME: This needs more work to be compatible with other engines.
// See https://www.w3.org/Bugs/Public/show_bug.cgi?id=10583
if (!m_range)
return String::empty();
return DeprecatedString::empty();
return m_range->to_string();
}

4
Userland/Libraries/LibWeb/Selection/Selection.h
View file

@ -31,7 +31,7 @@ public:
unsigned focus_offset() const;
bool is_collapsed() const;
unsigned range_count() const;
String type() const;
DeprecatedString type() const;
WebIDL::ExceptionOr<JS::GCPtr<DOM::Range>> get_range_at(unsigned index);
void add_range(JS::NonnullGCPtr<DOM::Range>);
WebIDL::ExceptionOr<void> remove_range(JS::NonnullGCPtr<DOM::Range>);
@ -48,7 +48,7 @@ public:
delete_from_document();
bool contains_node(JS::NonnullGCPtr<DOM::Node>, bool allow_partial_containment) const;
String to_string() const;
DeprecatedString to_string() const;
private:
Selection(JS::NonnullGCPtr<JS::Realm>, JS::NonnullGCPtr<DOM::Document>);