RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 16:57:36 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/UIEvents/KeyboardEvent.cpp
View file

@ -69,8 +69,8 @@ static unsigned long determine_key_code(KeyCode platform_key, u32 code_point)
KeyboardEvent* KeyboardEvent::create_from_platform_event(JS::Realm& realm, FlyString const& event_name, KeyCode platform_key, unsigned modifiers, u32 code_point)
{
// FIXME: Figure out what these should actually contain.
String event_key = key_code_to_string(platform_key);
String event_code = "FIXME";
DeprecatedString event_key = key_code_to_string(platform_key);
DeprecatedString event_code = "FIXME";
auto key_code = determine_key_code(platform_key, code_point);
KeyboardEventInit event_init {};
@ -91,7 +91,7 @@ KeyboardEvent* KeyboardEvent::create_from_platform_event(JS::Realm& realm, FlySt
return KeyboardEvent::create(realm, event_name, event_init);
}
bool KeyboardEvent::get_modifier_state(String const& key_arg)
bool KeyboardEvent::get_modifier_state(DeprecatedString const& key_arg)
{
if (key_arg == "Alt")
return m_alt_key;

14
Userland/Libraries/LibWeb/UIEvents/KeyboardEvent.h
View file

@ -14,8 +14,8 @@
namespace Web::UIEvents {
struct KeyboardEventInit : public EventModifierInit {
String key { "" };
String code { "" };
DeprecatedString key { "" };
DeprecatedString code { "" };
u32 location { 0 };
bool repeat { false };
bool is_composing { false };
@ -37,8 +37,8 @@ public:
u32 key_code() const { return m_key_code; }
u32 char_code() const { return m_char_code; }
String key() const { return m_key; }
String code() const { return m_code; }
DeprecatedString key() const { return m_key; }
DeprecatedString code() const { return m_code; }
u32 location() const { return m_location; }
bool ctrl_key() const { return m_ctrl_key; }
@ -49,15 +49,15 @@ public:
bool repeat() const { return m_repeat; }
bool is_composing() const { return m_is_composing; }
bool get_modifier_state(String const& key_arg);
bool get_modifier_state(DeprecatedString const& key_arg);
virtual u32 which() const override { return m_key_code; }
private:
KeyboardEvent(JS::Realm&, FlyString const& event_name, KeyboardEventInit const& event_init);
String m_key;
String m_code;
DeprecatedString m_key;
DeprecatedString m_code;
u32 m_location { 0 };
bool m_ctrl_key { false };
bool m_shift_key { false };

2
Userland/Libraries/LibWeb/UIEvents/UIEvent.h
View file

@ -30,7 +30,7 @@ public:
int detail() const { return m_detail; }
virtual u32 which() const { return 0; }
void init_ui_event(String const& type, bool bubbles, bool cancelable, HTML::Window* view, int detail)
void init_ui_event(DeprecatedString const& type, bool bubbles, bool cancelable, HTML::Window* view, int detail)
{
init_event(type, bubbles, cancelable);
m_view = view;