RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 00:07:35 +00:00
Code Issues Activity Actions

AK+Everywhere: Rename String to DeprecatedString

Browse source 
We have a new, improved string type coming up in AK (OOM aware, no null
state), and while it's going to use UTF-8, the name UTF8String is a
mouthful - so let's free up the String name by renaming the existing
class.
Making the old one have an annoying name will hopefully also help with
quick adoption :^)
This commit is contained in:
Linus Groh 2022-12-04 18:02:33 +00:00 • committed by Andreas Kling
parent f74251606d
commit 6e19ab2bbc
2006 changed files with 11635 additions and 11636 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Services/InspectorServer/ConnectionFromClient.cpp
View file

@ -27,7 +27,7 @@ Messages::InspectorServer::GetAllObjectsResponse ConnectionFromClient::get_all_o
{
auto process = InspectableProcess::from_pid(pid);
if (!process)
return String {};
return DeprecatedString {};
JsonObject request;
request.set("type", "GetAllObjects");
@ -49,7 +49,7 @@ Messages::InspectorServer::SetInspectedObjectResponse ConnectionFromClient::set_
return true;
}
Messages::InspectorServer::SetObjectPropertyResponse ConnectionFromClient::set_object_property(pid_t pid, u64 object_id, String const& name, String const& value)
Messages::InspectorServer::SetObjectPropertyResponse ConnectionFromClient::set_object_property(pid_t pid, u64 object_id, DeprecatedString const& name, DeprecatedString const& value)
{
auto process = InspectableProcess::from_pid(pid);
if (!process)
@ -68,7 +68,7 @@ Messages::InspectorServer::IdentifyResponse ConnectionFromClient::identify(pid_t
{
auto process = InspectableProcess::from_pid(pid);
if (!process)
return String {};
return DeprecatedString {};
JsonObject request;
request.set("type", "Identify");

2
Userland/Services/InspectorServer/ConnectionFromClient.h
View file

@ -27,7 +27,7 @@ private:
virtual Messages::InspectorServer::GetAllObjectsResponse get_all_objects(pid_t) override;
virtual Messages::InspectorServer::SetInspectedObjectResponse set_inspected_object(pid_t, u64 object_id) override;
virtual Messages::InspectorServer::SetObjectPropertyResponse set_object_property(pid_t, u64 object_id, String const& name, String const& value) override;
virtual Messages::InspectorServer::SetObjectPropertyResponse set_object_property(pid_t, u64 object_id, DeprecatedString const& name, DeprecatedString const& value) override;
virtual Messages::InspectorServer::IdentifyResponse identify(pid_t) override;
virtual Messages::InspectorServer::IsInspectableResponse is_inspectable(pid_t) override;
};

4
Userland/Services/InspectorServer/InspectableProcess.cpp
View file

@ -34,7 +34,7 @@ InspectableProcess::InspectableProcess(pid_t pid, NonnullOwnPtr<Core::Stream::Lo
};
}
String InspectableProcess::wait_for_response()
DeprecatedString InspectableProcess::wait_for_response()
{
if (m_socket->is_eof()) {
dbgln("InspectableProcess disconnected: PID {}", m_pid);
@ -70,7 +70,7 @@ String InspectableProcess::wait_for_response()
VERIFY(data_buffer.size() == length);
dbgln("Got data size {} and read that many bytes", length);
return String::copy(data_buffer);
return DeprecatedString::copy(data_buffer);
}
void InspectableProcess::send_request(JsonObject const& request)

2
Userland/Services/InspectorServer/InspectableProcess.h
View file

@ -16,7 +16,7 @@ public:
~InspectableProcess() = default;
void send_request(JsonObject const& request);
String wait_for_response();
DeprecatedString wait_for_response();
static InspectableProcess* from_pid(pid_t);

6
Userland/Services/InspectorServer/InspectorServer.ipc
View file

@ -1,8 +1,8 @@
endpoint InspectorServer
{
get_all_objects(i32 pid) => (String json)
get_all_objects(i32 pid) => (DeprecatedString json)
set_inspected_object(i32 pid, u64 object_id) => (bool success)
set_object_property(i32 pid, u64 object_id, String name, String value) => (bool success)
identify(i32 pid) => (String json)
set_object_property(i32 pid, u64 object_id, DeprecatedString name, DeprecatedString value) => (bool success)
identify(i32 pid) => (DeprecatedString json)
is_inspectable(i32 pid) => (bool inspectable)
}