From 6e54d0c072912dd59fdd92f7f28ef90ef21daa1b Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Sun, 2 Aug 2020 10:48:48 -0700 Subject: [PATCH] AK: Remove relative_paths test from TestLexicalPath This test appears to be testing functionality that doesn't exist. Just remove it. Closes old bug #2388 CC @bugaevc --- AK/Tests/TestLexicalPath.cpp | 49 ++++-------------------------------- 1 file changed, 5 insertions(+), 44 deletions(-) diff --git a/AK/Tests/TestLexicalPath.cpp b/AK/Tests/TestLexicalPath.cpp index 5fe6a0efa1..4d4a431af9 100644 --- a/AK/Tests/TestLexicalPath.cpp +++ b/AK/Tests/TestLexicalPath.cpp @@ -52,75 +52,36 @@ TEST_CASE(dotdot_coalescing) EXPECT_EQ(LexicalPath("/../../../../").string(), "/"); } -// Temporarily disabled, as they were broken by commit a3e4dfdf9859a9b955bf4728328f740a47de5851 -// -#if 0 - -TEST_CASE(relative_paths) -{ - { - LexicalPath path("simple"); - EXPECT_EQ(path.is_valid(), true); - EXPECT_EQ(path.string(), "./simple"); - EXPECT_EQ(path.parts().size(), 2u); - EXPECT_EQ(path.basename(), "simple"); - } - { - LexicalPath path("a/relative/path"); - EXPECT_EQ(path.is_valid(), true); - EXPECT_EQ(path.string(), "./a/relative/path"); - EXPECT_EQ(path.parts().size(), 4u); - EXPECT_EQ(path.basename(), "path"); - } - { - LexicalPath path("./././foo"); - EXPECT_EQ(path.is_valid(), true); - EXPECT_EQ(path.string(), "./foo"); - EXPECT_EQ(path.parts().size(), 2u); - EXPECT_EQ(path.basename(), "foo"); - } - - { - LexicalPath path("."); - EXPECT_EQ(path.is_valid(), true); - EXPECT_EQ(path.string(), "."); - EXPECT_EQ(path.parts().size(), 1u); - EXPECT_EQ(path.basename(), "."); - } -} - TEST_CASE(has_extension) { { - FileSystemPath path("/tmp/simple.png"); + LexicalPath path("/tmp/simple.png"); EXPECT(path.has_extension(".png")); EXPECT(path.has_extension(".pnG")); EXPECT(path.has_extension(".PNG")); } { - FileSystemPath path("/TMP/SIMPLE.PNG"); + LexicalPath path("/TMP/SIMPLE.PNG"); EXPECT(path.has_extension(".png")); EXPECT(path.has_extension(".pnG")); EXPECT(path.has_extension(".PNG")); } { - FileSystemPath path(".png"); + LexicalPath path(".png"); EXPECT(path.has_extension(".png")); } { - FileSystemPath path; + LexicalPath path; EXPECT_EQ(path.has_extension(".png"), false); } { - FileSystemPath path("png"); + LexicalPath path("png"); EXPECT_EQ(path.has_extension(".png"), false); } } -#endif - TEST_MAIN(LexicalPath)